doc: document PerformanceNodeTiming.environment field#28280
Closed
yvasiyarov wants to merge 1 commit intonodejs:masterfrom
Closed
doc: document PerformanceNodeTiming.environment field#28280yvasiyarov wants to merge 1 commit intonodejs:masterfrom
yvasiyarov wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
doc
Trott
requested changes
Jun 18, 2019
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Welcome @yvasiyarov and thanks for the pull request! If you look at the other performanceNodeTiming entries, they are in alphabetical order. So instead of putting this one at the end, can you put it in the alphabetized location in the list? Thanks!
yvasiyarov
force-pushed
the
perf_hook_doc
branch
from
db6244d to
3cb7665
Compare
Author
|
@Trott fixed. commit squashed with original commit |
BridgeAR
approved these changes
Jun 19, 2019
cjihrig
approved these changes
Jun 19, 2019
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM with the sorting nit addressed.
trivikr
approved these changes
Jun 19, 2019
Trott
approved these changes
Jun 20, 2019
Trott
added
the
author ready
Member
Member
|
Landed in 7334aaf |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 21, 2019
PR-URL: nodejs#28280 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Member
|
Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
PR-URL: #28280 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes