Skip to content

doc: clarify when http emits aborted event#28262

Closed
ronag wants to merge 2 commits intonodejs:masterfrom
nxtedition:fix-aborted-docs
Closed

doc: clarify when http emits aborted event#28262
ronag wants to merge 2 commits intonodejs:masterfrom
nxtedition:fix-aborted-docs

Conversation

@ronag
Copy link
Member

@ronag ronag commented Jun 17, 2019 •
edited
Loading

Clarify premature close and response object behaviour.

Ref: #28172

Checklist
  • documentation is changed or added
  • commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Jun 17, 2019
Trott
Trott reviewed Jun 17, 2019
View reviewed changes
Trott
Trott approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subsystem for the commit message should be doc:. Maybe something like doc: clarify when http emits aborted event? This is something that can be handled by whoever lands the PR but if you want to save someone a few keystrokes, by all means, amend the commit message and force push.

@ronag ronag force-pushed the fix-aborted-docs branch from 0950acc to 8fbda01 Compare June 17, 2019 23:15
Trott
Trott reviewed Jun 18, 2019
View reviewed changes
@ronag @Trott
Update doc/api/http.md
cbbc403 
Co-Authored-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Jun 18, 2019

@nodejs/http (just in case this is a bug that needs to be fixed rather than a peculiarity that needs to be documented or something like that)

@trivikr trivikr changed the title http: clarify aborted doc: clarify when http emits aborted event Jun 18, 2019
@ronag
Copy link
Member Author

ronag commented Jun 18, 2019

This is relevant #28172 and argues a change in behaviour. However, if or until then I suggest we should clarify the existing behaviour.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 18, 2019
@Trott
Copy link
Member

Trott commented Jun 18, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3689/

@addaleax
Copy link
Member

addaleax commented Jun 19, 2019

Landed in 1a4f27a

@addaleax addaleax closed this Jun 19, 2019
addaleax pushed a commit that referenced this pull request Jun 19, 2019
@ronag @addaleax
doc: clarify when http emits aborted event
1a4f27a 
PR-URL: #28262
Refs: #28172
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Jul 2, 2019
@ronag @targos
doc: clarify when http emits aborted event
359e20f 
PR-URL: #28262
Refs: #28172
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@fhinkel fhinkel fhinkel approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ronag @Trott @addaleax @fhinkel @BridgeAR @trivikr @nodejs-github-bot