Skip to content

test: document cpu-prof module and remove unused output argument from getFrames() #28183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
Jun 14, 2019
Merged

test: document cpu-prof module and remove unused output argument from getFrames() #28183

merged 0 commits into from
Jun 14, 2019

Conversation

@Trott
Copy link
Member

@Trott Trott commented Jun 11, 2019

test: document cpu-prof module and remove unused output argument from getFrames()

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 11, 2019
@Trott Trott requested a review from joyeecheung June 11, 2019 20:58
@Trott

This comment has been minimized.

Sign in to view
@Trott

This comment has been minimized.

Sign in to view
joyeecheung
joyeecheung reviewed Jun 11, 2019
View reviewed changes
richardlau
richardlau reviewed Jun 11, 2019
View reviewed changes
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 12, 2019
@Trott

This comment has been minimized.

Sign in to view
joyeecheung
joyeecheung reviewed Jun 12, 2019
View reviewed changes
Trott
Trott commented Jun 12, 2019
View reviewed changes
@Trott
Copy link
Member Author

Trott commented Jun 12, 2019

Guess I should fix the ReferenceError I introduced....

@Trott
Copy link
Member Author

Trott commented Jun 12, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23817/

@Trott
Copy link
Member Author

Trott commented Jun 14, 2019

Landed in 8cdc1bd...d4c7487

Trott added a commit to Trott/io.js that referenced this pull request Jun 14, 2019
@Trott
test: document cpu-prof module
06c818a 
PR-URL: nodejs#28183
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott added a commit to Trott/io.js that referenced this pull request Jun 14, 2019
@Trott
test: remove unused output argument for getFrames()
4928c2f 
PR-URL: nodejs#28183
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott closed this Jun 14, 2019
@Trott Trott force-pushed the stub-out-cpu-prof branch from cda56ca to d4c7487 Compare June 14, 2019 06:03
@Trott Trott deleted the stub-out-cpu-prof branch June 14, 2019 06:03
@Trott Trott merged commit d4c7487 into nodejs:master Jun 14, 2019
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@Trott @BridgeAR
test: document cpu-prof module
5d8dce4 
PR-URL: #28183
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@Trott @BridgeAR
test: remove unused output argument for getFrames()
066d814 
PR-URL: #28183
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@Trott @BridgeAR
test: remove FIB environment variable from cpu-prof.js
414e9d2 
PR-URL: #28183
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
Merged
targos pushed a commit that referenced this pull request Jun 18, 2019
@Trott @targos
test: document cpu-prof module
58eccb1 
PR-URL: #28183
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 18, 2019
@Trott @targos
test: remove unused output argument for getFrames()
a3f8385 
PR-URL: #28183
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 18, 2019
@Trott @targos
test: remove FIB environment variable from cpu-prof.js
bd16f9b 
PR-URL: #28183
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheung joyeecheung joyeecheung left review comments

@jasnell jasnell jasnell approved these changes

@richardlau richardlau richardlau approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott @nodejs-github-bot @jasnell @joyeecheung @richardlau