util: support AsyncGeneratorFunction in .inspect #28056
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure async generator functions are properly detected while using `util.inspect`.
addaleax
approved these changes
Jun 4, 2019
BridgeAR
added
the
author ready
Collaborator
targos
approved these changes
Jun 4, 2019
ZYSzys
approved these changes
Jun 4, 2019
benjamingr
approved these changes
Jun 4, 2019
Collaborator
TimothyGu
approved these changes
Jun 5, 2019
cjihrig
approved these changes
Jun 5, 2019
trivikr
approved these changes
Jun 5, 2019
Trott
approved these changes
Jun 6, 2019
Member
|
Landed in a23c230 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 9, 2019
This makes sure async generator functions are properly detected while using `util.inspect`. PR-URL: nodejs#28056 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR
added a commit
that referenced
this pull request
Jun 17, 2019
This makes sure async generator functions are properly detected while using `util.inspect`. PR-URL: #28056 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure async generator functions are properly detected while
using
util.inspect.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes