build: add mips64el support by mutao-loongson · Pull Request #27992 · nodejs/node

mutao-loongson · 2019-05-31T08:33:46Z

build: add support for mips64el

V8 now resume supporting for mipsel/mips64el, the support for mips platform
need to recover.

First, revert commit 9334 e45aa0ed815c2745bcc2bb606d91be64998d.

Second, add linux64-mips64 platform dependent files and update the corresponding
gypi files and header files for OpenSSL compiling.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

This reverts commit 9334e45.

V8 now resume supporting for mipsel/mips64el. This commit add linux64-mips64 platform dependent files in 'deps/openssl/config/archs/linux64-mips64', and update the corresponding gypi files and header files. Refs: https://groups.google.com/forum/#!topic/v8-dev/oXkv5OVCXyc

refack · 2019-05-31T18:54:08Z

Hello @mutao-loongson, and thank you for the contribution!

I would really be happy if we could get some sort of CI for this, preferably under the https://github.com/nodejs/unofficial-builds initiative. Could you help with that?

mutao-loongson · 2019-06-03T04:58:48Z

Hello @mutao-loongson, and thank you for the contribution!

I would really be happy if we could get some sort of CI for this, preferably under the https://github.com/nodejs/unofficial-builds initiative. Could you help with that?

I would love to do something for nodejs community. I have read https://github.com/nodejs/unofficial-builds. It only copes with compiling stage of CI, no tests stage.

What you mean by "some sort of CI"? Could you explain further for that ? What I need to do to offer help? And what need to do to make mips64el to be one of the platforms that nodejs officially supports ?

Please give me some instructions.

bnoordhuis

LGTM (and RSLGTM w.r.t. to the openssl changes; they look correct but I didn't check every line.)

Having mipsel machines in the CI matrix would be nice but it's not as if we had those before. I'm okay with landing this as-is as long as it's understood that it comes with no warranty, no promise of support, etc.

(That includes timely review of mipsel-related pull requests ^^)

mutao-loongson · 2019-06-06T02:18:16Z

OK, I willing to spend time to support node for mipsel-related problems. First, I would following the advice from @refack to response to https://github.com/nodejs/unofficial-builds initiative. When opportunity matures, then, I would propose adding mipsel machines into the CI matrix.

Best Regards.

mutao-loongson · 2019-06-14T01:38:01Z

Hello, when could this pull request be landed ?

nodejs-github-bot · 2019-06-16T22:56:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/23913/

Trott · 2019-06-16T22:56:20Z

Hello, when could this pull request be landed ?

I believe the only remaining requirement is that it pass CI.

CI: https://ci.nodejs.org/job/node-test-pull-request/23913/

Also: /ping @nodejs/build in case anyone there has opinions or wants to do something CI-wise....

Trott · 2019-06-16T22:57:34Z

Also: /ping @nodejs/crypto in case anyone wants to look over the OpenSSL stuff

rvagg · 2019-06-17T01:19:30Z

This is really sweet. I don't have full confidence in the OpenSSL changes and would love for @sam-github or @shigeki to add their +1 to @bnoordhuis'.
Long-standing policy for platforms not officially supported is something like - we'll accept changes as long as they don't interfere with supported platforms and are not overly intrusive. These changes are very minimal and certainly pass that test IMO. Great work!

nodejs-github-bot · 2019-06-17T09:05:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/23935/

sam-github

As far as I can tell, this is purely additive, it doesn't change anything about node/openssl on currently supported platforms, and is pretty minimal (apart from the noise of auto-generated openssl config output), so LGTM.

mutao-loongson · 2019-06-18T01:14:58Z

Yes, I don't change anything about node/openssl on currently supported platform. I just modified some gypi and header files and added auto-generated openssl config output to add mips64el compiling support. But CI can't pass ?! I am confused! I will setup win2008r2-vs2017 envrionment in virtual machine to try to reproduce the failure and try to figure out what wrong with "node-test-binary-windows-2" test case.

nodejs-github-bot · 2019-06-18T01:27:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/23950/

rvagg · 2019-06-18T04:24:31Z

I think you just hit a flaky test @mutao-loongson, the re-run is green(ish) so this is good to go I think.

rvagg · 2019-06-18T04:29:16Z

Landed in 2a9f1ad...779a243

This reverts commit 9334e45. PR-URL: #27992 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

V8 now resume supporting for mipsel/mips64el. This commit add linux64-mips64 platform dependent files in 'deps/openssl/config/archs/linux64-mips64', and update the corresponding gypi files and header files. Refs: https://groups.google.com/forum/#!topic/v8-dev/oXkv5OVCXyc PR-URL: #27992 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

mutao-loongson · 2019-06-18T15:01:20Z

Thanks @rvagg , I would not try to reproduce the failure anymore.

This reverts commit 9334e45. PR-URL: #27992 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

V8 now resume supporting for mipsel/mips64el. This commit add linux64-mips64 platform dependent files in 'deps/openssl/config/archs/linux64-mips64', and update the corresponding gypi files and header files. Refs: https://groups.google.com/forum/#!topic/v8-dev/oXkv5OVCXyc PR-URL: #27992 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

Notable changes: * build: * Experimental support for building Node.js on MIPS architecture is back. #27992 * child_process: * The promisified versions of `child_process.exec` and `child_process.execFile` now both return a `Promise` which has the child instance attached to their `child` property. #28325 * deps: * Updated libuv to 1.30.0. #28449 * Support for the Haiku platform has been added. * The maximum `UV_THREADPOOL_SIZE` has been increased from 128 to 1024. * `uv_fs_copyfile()` now works properly when the source and destination files are the same. * process: * A new method, `process.resourceUsage()` was added. It returns resource usage for the current process, such as CPU time. #28018 * src: * Fixed an issue related to stdio that could lead to a crash of the process in some circumstances. #28490 * stream: * Added a `writableFinished` property to writable streams. It indicates that all the data has been flushed to the underlying system. #28007 * worker: * Fixed an issue that prevented worker threads to listen for data on stdin. #28153 PR-URL: #28508

Notable changes: * build: * Experimental support for building Node.js on MIPS architecture is back. #27992 * child_process: * The promisified versions of `child_process.exec` and `child_process.execFile` now both return a `Promise` which has the child instance attached to their `child` property. #28325 * deps: * Updated libuv to 1.30.0. #28449 * Support for the Haiku platform has been added. * The maximum `UV_THREADPOOL_SIZE` has been increased from 128 to 1024. * `uv_fs_copyfile()` now works properly when the source and destination files are the same. * process: * A new method, `process.resourceUsage()` was added. It returns resource usage for the current process, such as CPU time. #28018 * src: * Fixed an issue related to stdio that could lead to a crash of the process in some circumstances. #28490 * stream: * Added a `writableFinished` property to writable streams. It indicates that all the data has been flushed to the underlying system. #28007 * worker: * Fixed an issue that prevented worker threads to listen for data on stdin. #28153 * meta: * Added Jiawen Geng (https://github.com/gengjiawen) to collaborators. #28322 PR-URL: #28508

Notable changes: * build: * Experimental support for building Node.js on MIPS architecture is back. #27992 * child_process: * The promisified versions of `child_process.exec` and `child_process.execFile` now both return a `Promise` which has the child instance attached to their `child` property. #28325 * deps: * Updated libuv to 1.30.1. #28449, #28511 * Support for the Haiku platform has been added. * The maximum `UV_THREADPOOL_SIZE` has been increased from 128 to 1024. * `uv_fs_copyfile()` now works properly when the source and destination files are the same. * process: * A new method, `process.resourceUsage()` was added. It returns resource usage for the current process, such as CPU time. #28018 * src: * Fixed an issue related to stdio that could lead to a crash of the process in some circumstances. #28490 * stream: * Added a `writableFinished` property to writable streams. It indicates that all the data has been flushed to the underlying system. #28007 * worker: * Fixed an issue that prevented worker threads to listen for data on stdin. #28153 * meta: * Added Jiawen Geng (https://github.com/gengjiawen) to collaborators. #28322 PR-URL: #28508

mutao-loongson added 2 commits May 31, 2019 15:44

Revert "build: remove mips support"

327b63f

This reverts commit 9334e45.

nodejs-github-bot added build Issues and PRs related to build files or the CI. openssl Issues and PRs related to the OpenSSL dependency. labels May 31, 2019

BridgeAR requested review from bnoordhuis, cjihrig and refack June 4, 2019 13:33

bnoordhuis approved these changes Jun 5, 2019

View reviewed changes

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 16, 2019

rvagg added the mips Issues and PRs related to the MIPS architecture. label Jun 17, 2019

rvagg approved these changes Jun 17, 2019

View reviewed changes

sam-github approved these changes Jun 17, 2019

View reviewed changes

rvagg closed this Jun 18, 2019

rvagg pushed a commit that referenced this pull request Jun 18, 2019

Revert "build: remove mips support"

eaddb22

This reverts commit 9334e45. PR-URL: #27992 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

mutao-loongson deleted the deps-openssl-mips64el-asm-support branch June 19, 2019 02:16

mutao-loongson restored the deps-openssl-mips64el-asm-support branch June 19, 2019 02:17

targos pushed a commit that referenced this pull request Jul 2, 2019

Revert "build: remove mips support"

2cf37f5

This reverts commit 9334e45. PR-URL: #27992 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

targos mentioned this pull request Jul 2, 2019

Release v12.6.0 proposal #28508

Merged

nxhack mentioned this pull request Jul 3, 2019

BAD NEWS: remove mips support nxhack/openwrt-node-packages#464

Closed

This was referenced Jul 3, 2019

2019-07-03 Version 12.6.0 (Current) @targos beevelop/docker-nodejs#288

Closed

2019-07-03 Version 12.6.0 (Current) @targos beevelop/docker-nodejs#289

Closed

2019-07-03 Version 12.6.0 (Current) @targos beevelop/docker-nodejs#290

Closed

Uh oh!

Conversation

mutao-loongson commented May 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

refack commented May 31, 2019

Uh oh!

mutao-loongson commented Jun 3, 2019

Uh oh!

bnoordhuis left a comment

Choose a reason for hiding this comment

Uh oh!

mutao-loongson commented Jun 6, 2019

Uh oh!

mutao-loongson commented Jun 14, 2019

Uh oh!

nodejs-github-bot commented Jun 16, 2019

Uh oh!

Trott commented Jun 16, 2019

Uh oh!

Trott commented Jun 16, 2019

Uh oh!

rvagg commented Jun 17, 2019

Uh oh!

nodejs-github-bot commented Jun 17, 2019

Uh oh!

sam-github left a comment

Choose a reason for hiding this comment

Uh oh!

mutao-loongson commented Jun 18, 2019

Uh oh!

nodejs-github-bot commented Jun 18, 2019

Uh oh!

rvagg commented Jun 18, 2019

Uh oh!

rvagg commented Jun 18, 2019

Uh oh!

mutao-loongson commented Jun 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mutao-loongson commented May 31, 2019 •

edited

Loading