build,meta: rearrange and narrow git ignore rules #27954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timofeichaplinskiy
approved these changes
May 29, 2019
Trott
reviewed
May 30, 2019
Trott
reviewed
May 30, 2019
Trott
approved these changes
May 30, 2019
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
A bit rubber-stamp-y of me, but LGTM.
targos
approved these changes
Jun 3, 2019
Collaborator
refack
added
build
PR-URL: nodejs#27954 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
PR-URL: #27954 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non trivial change to
.gitignorenode_modulesrules based on tools: update eslint #27670/coverage,iojs,tmp)might need more validation by human developers different platforms
as documented in the file:
To test conflicts, run
git ls-files -i --exclude-standard.To check why a specific file is ignored, run
git check-ignore -v [-n] [--no-index] <filepath>./CC @nodejs/build-files @nodejs/documentation @nodejs/testing @nodejs/linting
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes