[v10.x backport] esm: fix esm load bug#27874
Closed
aduh95 wants to merge 3 commits intonodejs:v10.x-stagingfrom
Closed
[v10.x backport] esm: fix esm load bug#27874aduh95 wants to merge 3 commits intonodejs:v10.x-stagingfrom
aduh95 wants to merge 3 commits intonodejs:v10.x-stagingfrom
Conversation
Fixes: nodejs#25482 PR-URL: nodejs#25491 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This test shows the regression introduced in v11.4.0: clearing out the require.cache crashes node when using the `--experimental-modules` flag. Refs: nodejs#25482 PR-URL: nodejs#25491 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
ZYSzys
reviewed
May 26, 2019
BethGriggs
approved these changes
May 30, 2019
Collaborator
ZYSzys
approved these changes
May 30, 2019
addaleax
added
the
esm
This comment has been minimized.
This comment has been minimized.
Collaborator
BethGriggs
pushed a commit
that referenced
this pull request
Jun 6, 2019
This test shows the regression introduced in v11.4.0: clearing out the require.cache crashes node when using the `--experimental-modules` flag. Refs: #25482 Backport-PR-URL: #27874 PR-URL: #25491 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
|
Landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: #25491
Fixes #27846
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes