Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "lib: print to stdout/stderr directly instead of using console" #27823

Closed
wants to merge 1 commit into from
Closed

Revert "lib: print to stdout/stderr directly instead of using console" #27823

wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

This reverts commit 2b24ffa.

Fixes: #27819

I've no idea how to test this as piping the output suppresses the ANSI escape sequences.

cc @joyeecheung

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@richardlau richardlau mentioned this pull request May 22, 2019
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23275/

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 22, 2019
@Fishrock123
Copy link
Contributor

@richardlau Do the escape sequences work to a pseudo-tty? Can it be put in those tests?

@richardlau richardlau added the lib / src Issues and PRs related to general changes in the lib or src directory. label May 22, 2019
@richardlau
Copy link
Member Author

@richardlau Do the escape sequences work to a pseudo-tty? Can it be put in those tests?

I don't know. The bug is with node -p process.versions -- #27320 changed the code so that -p bypassed the console. I'm not sure how the pseudo-tty fits in there.

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3598

@richardlau richardlau mentioned this pull request May 22, 2019
Closed
2 tasks
@richardlau

This comment has been minimized.

Sign in to view
@addaleax
Copy link
Member

Landed in 1a96abe

@addaleax addaleax closed this May 26, 2019
addaleax pushed a commit that referenced this pull request May 26, 2019
@richardlau @addaleax
Revert "lib: print to stdout/stderr directly instead of using console"
1a96abe 
This reverts commit 2b24ffa.

Fixes: #27819

PR-URL: #27823
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request May 28, 2019
@richardlau @targos
Revert "lib: print to stdout/stderr directly instead of using console"
9b90385 
This reverts commit 2b24ffa.

Fixes: #27819

PR-URL: #27823
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node -p process.verions display issue on Windows Cmd
10 participants
@richardlau @nodejs-github-bot @Fishrock123 @addaleax @ChALkeR @Trott @cjihrig @joyeecheung @gireeshpunathil @BridgeAR