Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12.3.0 proposal #27799

Merged
merged 129 commits into from
May 21, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
129 commits
Select commit Hold shift + click to select a range
e573c99
assert: fix `assert.fail()` stack
BridgeAR May 1, 2019
3367bad
assert: refine assertion message
BridgeAR May 1, 2019
ec642f1
assert: use less read operations
BridgeAR May 1, 2019
a5dab9e
test: deflake test-tls-js-stream
lpinca Apr 29, 2019
c0cdf30
doc: improve CCM example
tniessen Apr 24, 2019
c53a674
doc: add example to test doc for clarity
addityasingh May 4, 2019
b6e540a
test: fix flaky test-tls-multiple-cas-as-string
lpinca May 5, 2019
815a957
test: refactor test-tls-enable-trace-cli.js
cjihrig May 3, 2019
c78de13
repl: handle uncaughtException properly
BridgeAR May 17, 2018
b338d53
src: fix typos
gengjiawen May 6, 2019
a23e86f
doc: add Sam Roberts to TSC
rvagg May 8, 2019
2f512e3
module: handle relative paths in resolve paths
cjihrig May 7, 2019
d2d3bf8
inspector: code cleanup
May 6, 2019
766a731
build: export OpenSSL UI symbols
sam-github May 6, 2019
8a1f2d0
doc: doc deprecate the legacy http parser
cjihrig May 9, 2019
876441e
meta: move orangemocha to Collaborator Emeriti list
Trott May 9, 2019
14d58c2
meta: move pmq20 to Collaborator Emeriti list
Trott May 7, 2019
6bef4c0
meta: move AnnaMag to Collaborator Emeriti list
Trott May 7, 2019
217e6b5
tools: switch to camelcasing in apilinks.js
Trott May 8, 2019
fd823ea
tools: enable camelcase linting in tools
Trott May 8, 2019
66cf89f
doc: move Rod Vagg to TSC emeritus
rvagg May 9, 2019
62fe342
src: refactor deprecated UVException usage in pipe-wrap.cc
gengjiawen May 4, 2019
f6642e9
src: elevate namespaces in node_worker.cc
preveen-stack May 5, 2019
c6ab6b2
tools: enable block-scoped-var eslint rule
silverwind May 8, 2019
d7fcd75
test: remove unneeded `--expose-internals`
Trott May 8, 2019
691866f
test: fix test-linux-perf flakiness
mmarchini May 9, 2019
76c9e86
deps: patch V8 to 7.4.288.27
mmarchini May 8, 2019
b8b02c3
tls: add missing 'new'
cjihrig May 8, 2019
6624f80
tls: fix createSecureContext() cipher list filter
sam-github May 10, 2019
119a590
module: improve resolve paths validation
cjihrig May 8, 2019
3801859
test: add tests for hasItems method in FreeList
rpgeeganage May 6, 2019
172fa63
doc: simplify About This Documentation text
Trott May 9, 2019
a18692c
src: extract common macro to util.h
gengjiawen May 1, 2019
0c7f18e
test: test error when breakOnSigint is not a boolean for evaluate
rpgeeganage Apr 30, 2019
ea62149
meta: move firedfox to Collaborator Emeriti list
Trott May 9, 2019
8d448be
doc: simplify test/README.md
Trott May 9, 2019
8cba1af
test: better assertion for async hook tests
ofrobots May 7, 2019
3c70797
src: remove extra semicolons after macros
gengjiawen May 6, 2019
688a0bd
repl: do not run --eval code if there is none
addaleax May 6, 2019
88b4d00
lib: restore `global.module` after --eval code is run
addaleax May 6, 2019
c33e834
module: simplify createRequire() validation
cjihrig May 9, 2019
74046ce
http2: do not override the allowHalfOpen option
lpinca May 9, 2019
e74e661
async_hooks: only disable promise hook if wanted
addaleax May 6, 2019
169ddc5
tools: force common be required before any other modules
ZYSzys May 12, 2019
8a96182
module: add missing space in error message
cjihrig May 9, 2019
7923b4a
doc: add call-once note to napi_queue_async_work
May 6, 2019
140b44f
module: fix createRequireFromPath() slash logic
cjihrig May 10, 2019
1365683
tools: allow RegExp in required-modules eslint rule
richardlau May 11, 2019
d2e1efe
src: fix warnings about redefined BSWAP macros
sam-github May 10, 2019
e736e20
src: declare unused priv argument
sam-github May 9, 2019
ae8b64d
src: remove util-inl.h from header files
sam-github May 9, 2019
f01183c
test: move dgram invalid host test to internet tests
May 4, 2019
9ed5882
test: use common.PORT instead of an extraneous variable
May 5, 2019
493ead1
assert: loose deep equal should not compare symbol properties
BridgeAR May 11, 2019
4dbebfd
lib: fix typo in pre_execution.js
gengjiawen May 11, 2019
b5498ed
doc,meta: codify security release commit message
richardlau May 10, 2019
7252a64
test: pass null params to napi_xxx_property()
Apr 25, 2019
8f48edd
vm: mark global proxy as side-effect-free
addaleax May 1, 2019
cc45080
doc: dns.lookup() documentation error code
jvelezpo May 9, 2019
c7e5fca
deps: make VC-WIN config generation deterministic
jkunkee May 2, 2019
da4a379
doc: format correction for experimental loader hooks
dnalborczyk May 2, 2019
89fda94
esm: fix esm load bug
ZYSzys May 13, 2019
1757250
test: clearing require cache crashes esm loader
aduh95 May 2, 2019
314fdda
deps: regenerate OpenSSL configs with fixed tooling
jkunkee May 2, 2019
750556d
deps: update OpenSSL configs' timestamps
jkunkee May 2, 2019
1b8bc77
tools: add `12.x` to alternative docs versions
richardlau May 12, 2019
4ed8a9b
doc,tools: updates for 6.x End-of-Life
richardlau May 14, 2019
6f23816
fs: extract path conversion and validation to getValidatedPath
ZYSzys May 12, 2019
700459e
inspector: added NodeRuntime domain
alexkozy May 7, 2019
eb1f4e5
tls: expose keylog event on TLSSocket
mildsunrise May 11, 2019
d2dad0b
tools: DRY isRequireCall() in lint rules
cjihrig May 13, 2019
b380c0f
child_process: refactor stdioStringToArray function
zero1five May 12, 2019
ea62f4a
tools: update dmn to 2.2.2
Trott May 14, 2019
0393045
process: inspect error in case of a fatal exception
BridgeAR Apr 15, 2019
6983a0c
assert: add compatibility for older Node.js versions
BridgeAR May 13, 2019
47184d1
tools: update capitalized-comments eslint rule
BridgeAR May 13, 2019
7cc21d8
assert: remove unused code
BridgeAR May 13, 2019
6984ca1
util: reconstruct constructor in more cases
BridgeAR May 12, 2019
da102cd
console: don't attach unnecessary error handlers
cjihrig May 14, 2019
d570995
doc: remove non-existent entry-type flag
dnalborczyk May 13, 2019
fc8ad77
meta: move estliberitas to Collaborator Emeriti list
Trott May 14, 2019
47f913b
esm: --experimental-wasm-modules integration support
MylesBorins Apr 29, 2019
2e85642
meta: move whitlockjc to Collaborator Emeriti list
Trott May 14, 2019
9f9871c
meta: move chrisdickinson to Collaborator Emeriti list
Trott May 14, 2019
3ac4a71
meta: move jhamhader to Collaborator Emeriti list
Trott May 15, 2019
1f935f8
events: improve max listeners warning
BridgeAR May 14, 2019
b7ed4d7
worker: move `receiving_messages_` field to `MessagePort`
addaleax Apr 17, 2019
e004d42
worker: use special message as MessagePort close command
addaleax May 14, 2019
8b4101a
test: un-mark worker syntax error tests as flaky
addaleax May 14, 2019
e058900
build: add arm64 to vcbuild.bat help message
jkunkee May 13, 2019
74feb0b
process: mark process.env as side-effect-free
addaleax May 14, 2019
0e16b35
tools: decrease code duplication for isString() in lint rules
cjihrig May 15, 2019
05c3d53
stream: implement Readable.from async iterator utility
guybedford May 12, 2019
a66b391
http2: do no throw in writeHead if state.closed
mcollina May 13, 2019
0db846f
tools: refactor js2c.py for maximal Python3 compatibility
refack Jan 14, 2019
c3d1675
tools: remove unneeded dependency files
Trott May 16, 2019
e61823c
tls: support `net.Server` options
lpinca May 13, 2019
1f7a527
doc: clarify behavior of fs.mkdir
Gaelan Apr 30, 2019
c7cf8d9
worker: add ability to unshift message from MessagePort
addaleax Apr 17, 2019
767889b
doc,n-api: fix `introduced_in` metadata
richardlau May 17, 2019
6e2c8d0
doc,n-api: update N-API version matrix for v12.x
richardlau May 17, 2019
df01645
doc: correct entry for electron v4.0.4
jacobq Apr 24, 2019
cf516f7
doc: rewrite "About this Documentation" section
Trott May 16, 2019
f872210
test: relax check in verify-graph
Flarna May 16, 2019
6070e88
async_hooks: don't reuse resource in HttpAgent
Flarna May 5, 2019
4a9af17
http: add an alias at addListener on Server connection socket
himself65 Apr 20, 2019
32fd0ac
stream: use readableObjectMode public api for js stream
antsmartian May 19, 2019
24b26c0
inspector: fix typo
gengjiawen May 15, 2019
c746156
inspector: mark profile type const
gengjiawen May 15, 2019
83f2430
deps: V8: cherry-pick cca9ae3c9a
bmeurer May 15, 2019
bfb9356
http: do not default to chunked encoding for TRACE
lpinca May 13, 2019
206ae31
http: always call response.write() callback
lpinca May 15, 2019
d21e066
src: update UNREACHABLE macro to take a string
nitsakh Mar 8, 2019
026bebf
bootstrap: --frozen-intrinsics unfreeze console
guybedford May 13, 2019
f663e74
doc: remove stability highlight for stable functions
mhdawson May 17, 2019
a8a1186
tools: update markdown linter for Windows line endings
Trott May 17, 2019
bdd75d0
tls: expose built-in root certificates
bnoordhuis May 20, 2019
d8b4867
util: simplify inspection limit handling
BridgeAR May 16, 2019
099c9ce
util: unify constructor inspection in `util.inspect`
BridgeAR May 16, 2019
5205902
util: remove outdated comment
BridgeAR May 16, 2019
378f44c
doc: update `util.format` formatters documentation
BridgeAR May 13, 2019
10b4a81
util: if present, fallback to `toString` using the %s formatter
BridgeAR May 9, 2019
2bc177a
child_process: setup stdio on error when possible
cjihrig May 14, 2019
55fe340
doc: improve createRequire() example
cjihrig May 18, 2019
7e75086
doc: replace createRequireFromPath() references
cjihrig May 18, 2019
80f3074
esm: use correct error arguments
cjihrig May 18, 2019
d1da117
doc: correct parameter type on 'subprocess.kill([signal])'
himself65 May 18, 2019
9f5b690
doc: corrected tlsSocket.getPeerCertificate response type
dannyb648 May 17, 2019
20c11be
2019-05-21, Version 12.3.0 (Current)
BridgeAR May 21, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 4 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ module.exports = {
{
files: [
'doc/api/esm.md',
'doc/api/modules.md',
'test/es-module/test-esm-type-flag.js',
'test/es-module/test-esm-type-flag-alias.js',
'*.mjs',
Expand All @@ -59,13 +60,15 @@ module.exports = {
'array-callback-return': 'error',
'arrow-parens': ['error', 'always'],
'arrow-spacing': ['error', { before: true, after: true }],
'block-scoped-var': 'error',
'block-spacing': 'error',
'brace-style': ['error', '1tbs', { allowSingleLine: true }],
'capitalized-comments': ['error', 'always', {
line: {
// Ignore all lines that have less characters than 20 and all lines that
// start with something that looks like a variable name or code.
ignorePattern: '.{0,20}$|[a-z]+ ?[0-9A-Z_.(/=:[#-]|std',
// eslint-disable-next-line max-len
ignorePattern: '.{0,20}$|[a-z]+ ?[0-9A-Z_.(/=:[#-]|std|http|ssh|ftp|(let|var|const) [a-z_A-Z0-9]+ =|[b-z] |[a-z]*[0-9].* ',
ignoreInlineComments: true,
ignoreConsecutiveComments: true,
},
Expand Down
5 changes: 3 additions & 2 deletions BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -295,10 +295,11 @@ If you want to run the linter without running tests, use
`make lint`/`vcbuild lint`. It will run both JavaScript linting and
C++ linting.

If you are updating tests and just want to run a single test to check it:
If you are updating tests and want to run tests in a single test file
(e.g. `test/parallel/test-stream2-transform.js`):

```text
$ python tools/test.py -J --mode=release parallel/test-stream2-transform
$ python tools/test.py parallel/test-stream2-transform.js
```

You can execute the entire suite of tests for a given subsystem
Expand Down
53 changes: 3 additions & 50 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Select a Node.js version below to view the changelog history:
* [Node.js 9](doc/changelogs/CHANGELOG_V9.md) — End-of-Life
* [Node.js 8](doc/changelogs/CHANGELOG_V8.md) — Long Term Support
* [Node.js 7](doc/changelogs/CHANGELOG_V7.md) — End-of-Life
* [Node.js 6](doc/changelogs/CHANGELOG_V6.md) — Long Term Support
* [Node.js 6](doc/changelogs/CHANGELOG_V6.md) — End-of-Life
* [Node.js 5](doc/changelogs/CHANGELOG_V5.md) — End-of-Life
* [Node.js 4](doc/changelogs/CHANGELOG_V4.md) — End-of-Life
* [io.js](doc/changelogs/CHANGELOG_IOJS.md) — End-of-Life
Expand All @@ -26,11 +26,11 @@ release.
<th title="Current"><a href="doc/changelogs/CHANGELOG_V11.md">11</a><sup>Current</sup></th>
<th title="LTS Until 2021-04"><a href="doc/changelogs/CHANGELOG_V10.md">10</a><sup>LTS</sup></th>
<th title="LTS Until 2019-12"><a href="doc/changelogs/CHANGELOG_V8.md">8</a><sup>LTS</sup></th>
<th title="LTS Until 2019-04"><a href="doc/changelogs/CHANGELOG_V6.md">6</a><sup>LTS</sup></th>
</tr>
<tr>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V12.md#12.2.0">12.2.0</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V12.md#12.3.0">12.3.0</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V12.md#12.2.0">12.2.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V12.md#12.1.0">12.1.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V12.md#12.0.0">12.0.0</a><br/>
</td>
Expand Down Expand Up @@ -112,53 +112,6 @@ release.
<a href="doc/changelogs/CHANGELOG_V8.md#8.1.0">8.1.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V8.md#8.0.0">8.0.0</a><br/>
</td>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V6.md#6.17.1">6.17.1</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.17.0">6.17.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.16.0">6.16.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.15.1">6.15.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.15.0">6.15.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.14.4">6.14.4</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.14.3">6.14.3</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.14.2">6.14.2</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.14.1">6.14.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.14.0">6.14.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.13.1">6.13.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.13.0">6.13.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.12.3">6.12.3</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.12.2">6.12.2</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.12.1">6.12.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.12.0">6.12.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.11.5">6.11.5</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.11.4">6.11.4</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.11.3">6.11.3</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.11.2">6.11.2</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.11.1">6.11.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.11.0">6.11.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.10.3">6.10.3</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.10.2">6.10.2</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.10.1">6.10.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.10.0">6.10.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.9.5">6.9.5</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.9.4">6.9.4</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.9.3">6.9.3</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.9.2">6.9.2</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.9.1">6.9.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.9.0">6.9.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.8.1">6.8.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.8.0">6.8.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.7.0">6.7.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.6.0">6.6.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.5.0">6.5.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.4.0">6.4.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.3.1">6.3.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.3.0">6.3.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.2.2">6.2.2</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.2.1">6.2.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.2.0">6.2.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.1.0">6.1.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.0.0">6.0.0</a><br/>
</td>
</tr>
</table>

Expand Down
38 changes: 20 additions & 18 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,8 @@ For information about the governance of the Node.js project, see
**Michael Dawson** &lt;michael_dawson@ca.ibm.com&gt; (he/him)
* [MylesBorins](https://github.com/MylesBorins) -
**Myles Borins** &lt;myles.borins@gmail.com&gt; (he/him)
* [rvagg](https://github.com/rvagg) -
**Rod Vagg** &lt;rod@vagg.org&gt;
* [sam-github](https://github.com/sam-github) -
**Sam Roberts** &lt;vieuxtech@gmail.com&gt;
* [targos](https://github.com/targos) -
**Michaël Zasso** &lt;targos@protonmail.com&gt; (he/him)
* [thefourtheye](https://github.com/thefourtheye) -
Expand Down Expand Up @@ -230,6 +230,8 @@ For information about the governance of the Node.js project, see
**Alexis Campailla** &lt;orangemocha@nodejs.org&gt;
* [piscisaureus](https://github.com/piscisaureus) -
**Bert Belder** &lt;bertbelder@gmail.com&gt;
* [rvagg](https://github.com/rvagg) -
**Rod Vagg** &lt;r@va.gg&gt;
* [shigeki](https://github.com/shigeki) -
**Shigeki Ohtsu** &lt;ohtsu@ohtsu.org&gt; (he/him)
* [TimothyGu](https://github.com/TimothyGu) -
Expand All @@ -245,8 +247,6 @@ For information about the governance of the Node.js project, see
**Aleksei Koziatinskii** &lt;ak239spb@gmail.com&gt;
* [AndreasMadsen](https://github.com/AndreasMadsen) -
**Andreas Madsen** &lt;amwebdk@gmail.com&gt; (he/him)
* [AnnaMag](https://github.com/AnnaMag) -
**Anna M. Kedzierska** &lt;anna.m.kedzierska@gmail.com&gt;
* [antsmartian](https://github.com/antsmartian) -
**Anto Aravinth** &lt;anto.aravinth.cse@gmail.com&gt; (he/him)
* [apapirovski](https://github.com/apapirovski) -
Expand Down Expand Up @@ -281,8 +281,6 @@ For information about the governance of the Node.js project, see
**Christian Clauss** &lt;cclauss@me.com&gt; (he/him)
* [ChALkeR](https://github.com/ChALkeR) -
**Сковорода Никита Андреевич** &lt;chalkerx@gmail.com&gt; (he/him)
* [chrisdickinson](https://github.com/chrisdickinson) -
**Chris Dickinson** &lt;christopher.s.dickinson@gmail.com&gt;
* [cjihrig](https://github.com/cjihrig) -
**Colin Ihrig** &lt;cjihrig@gmail.com&gt; (he/him)
* [claudiorodriguez](https://github.com/claudiorodriguez) -
Expand All @@ -303,16 +301,12 @@ For information about the governance of the Node.js project, see
**Adrian Estrada** &lt;edsadr@gmail.com&gt; (he/him)
* [eljefedelrodeodeljefe](https://github.com/eljefedelrodeodeljefe) -
**Robert Jefe Lindstaedt** &lt;robert.lindstaedt@gmail.com&gt;
* [estliberitas](https://github.com/estliberitas) -
**Alexander Makarenko** &lt;estliberitas@gmail.com&gt;
* [eugeneo](https://github.com/eugeneo) -
**Eugene Ostroukhov** &lt;eostroukhov@google.com&gt;
* [evanlucas](https://github.com/evanlucas) -
**Evan Lucas** &lt;evanlucas@me.com&gt; (he/him)
* [fhinkel](https://github.com/fhinkel) -
**Franziska Hinkelmann** &lt;franziska.hinkelmann@gmail.com&gt; (she/her)
* [firedfox](https://github.com/firedfox) -
**Daniel Wang** &lt;wangyang0123@gmail.com&gt;
* [Fishrock123](https://github.com/Fishrock123) -
**Jeremiah Senkpiel** &lt;fishrock123@rocketmail.com&gt;
* [gabrielschulhof](https://github.com/gabrielschulhof) -
Expand Down Expand Up @@ -349,8 +343,6 @@ For information about the governance of the Node.js project, see
**Johan Bergström** &lt;bugs@bergstroem.nu&gt;
* [jdalton](https://github.com/jdalton) -
**John-David Dalton** &lt;john.david.dalton@gmail.com&gt;
* [jhamhader](https://github.com/jhamhader) -
**Yuval Brik** &lt;yuval@brik.org.il&gt;
* [jkrems](https://github.com/jkrems) -
**Jan Krems** &lt;jan.krems@gmail.com&gt; (he/him)
* [joaocgreis](https://github.com/joaocgreis) -
Expand Down Expand Up @@ -399,12 +391,8 @@ For information about the governance of the Node.js project, see
**Teddy Katz** &lt;teddy.katz@gmail.com&gt; (he/him)
* [ofrobots](https://github.com/ofrobots) -
**Ali Ijaz Sheikh** &lt;ofrobots@google.com&gt; (he/him)
* [orangemocha](https://github.com/orangemocha) -
**Alexis Campailla** &lt;orangemocha@nodejs.org&gt;
* [oyyd](https://github.com/oyyd) -
**Ouyang Yadong** &lt;oyydoibh@gmail.com&gt; (he/him)
* [pmq20](https://github.com/pmq20) -
**Minqi Pan** &lt;pmq2001@gmail.com&gt;
* [princejwesley](https://github.com/princejwesley) -
**Prince John Wesley** &lt;princejohnwesley@gmail.com&gt;
* [psmarshall](https://github.com/psmarshall) -
Expand Down Expand Up @@ -471,8 +459,6 @@ For information about the governance of the Node.js project, see
**Daijiro Wachi** &lt;daijiro.wachi@gmail.com&gt; (he/him)
* [watson](https://github.com/watson) -
**Thomas Watson** &lt;w@tson.dk&gt;
* [whitlockjc](https://github.com/whitlockjc) -
**Jeremy Whitlock** &lt;jwhitlock@apache.org&gt;
* [XadillaX](https://github.com/XadillaX) -
**Khaidi Chu** &lt;i@2333.moe&gt; (he/him)
* [yhwang](https://github.com/yhwang) -
Expand All @@ -488,10 +474,20 @@ For information about the governance of the Node.js project, see

* [andrasq](https://github.com/andrasq) -
**Andras** &lt;andras@kinvey.com&gt;
* [AnnaMag](https://github.com/AnnaMag) -
**Anna M. Kedzierska** &lt;anna.m.kedzierska@gmail.com&gt;
* [estliberitas](https://github.com/estliberitas) -
**Alexander Makarenko** &lt;estliberitas@gmail.com&gt;
* [chrisdickinson](https://github.com/chrisdickinson) -
**Chris Dickinson** &lt;christopher.s.dickinson@gmail.com&gt;
* [firedfox](https://github.com/firedfox) -
**Daniel Wang** &lt;wangyang0123@gmail.com&gt;
* [imran-iq](https://github.com/imran-iq) -
**Imran Iqbal** &lt;imran@imraniqbal.org&gt;
* [isaacs](https://github.com/isaacs) -
**Isaac Z. Schlueter** &lt;i@izs.me&gt;
* [jhamhader](https://github.com/jhamhader) -
**Yuval Brik** &lt;yuval@brik.org.il&gt;
* [lxe](https://github.com/lxe) -
**Aleksey Smolenchuk** &lt;lxe@lxe.co&gt;
* [matthewloring](https://github.com/matthewloring) -
Expand All @@ -504,6 +500,8 @@ For information about the governance of the Node.js project, see
**Christopher Monsanto** &lt;chris@monsan.to&gt;
* [Olegas](https://github.com/Olegas) -
**Oleg Elifantiev** &lt;oleg@elifantiev.ru&gt;
* [orangemocha](https://github.com/orangemocha) -
**Alexis Campailla** &lt;orangemocha@nodejs.org&gt;
* [othiym23](https://github.com/othiym23) -
**Forrest L Norvell** &lt;ogd@aoaioxxysz.net&gt; (he/him)
* [petkaantonov](https://github.com/petkaantonov) -
Expand All @@ -512,6 +510,8 @@ For information about the governance of the Node.js project, see
**Phillip Johnsen** &lt;johphi@gmail.com&gt;
* [piscisaureus](https://github.com/piscisaureus) -
**Bert Belder** &lt;bertbelder@gmail.com&gt;
* [pmq20](https://github.com/pmq20) -
**Minqi Pan** &lt;pmq2001@gmail.com&gt;
* [rlidwka](https://github.com/rlidwka) -
**Alex Kocharin** &lt;alex@kocharin.ru&gt;
* [rmg](https://github.com/rmg) -
Expand All @@ -528,6 +528,8 @@ For information about the governance of the Node.js project, see
**Mike Tunnicliffe** &lt;m.j.tunnicliffe@gmail.com&gt;
* [vsemozhetbyt](https://github.com/vsemozhetbyt) -
**Vse Mozhet Byt** &lt;vsemozhetbyt@gmail.com&gt; (he/him)
* [whitlockjc](https://github.com/whitlockjc) -
**Jeremy Whitlock** &lt;jwhitlock@apache.org&gt;

Collaborators follow the [COLLABORATOR_GUIDE.md](./COLLABORATOR_GUIDE.md) in
maintaining the Node.js project.
Expand Down
3 changes: 2 additions & 1 deletion benchmark/fixtures/simple-http-server.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@ const storedUnicode = Object.create(null);
const useDomains = process.env.NODE_USE_DOMAINS;

// Set up one global domain.
let domain;
if (useDomains) {
var domain = require('domain');
domain = require('domain');
const gdom = domain.create();
gdom.on('error', (er) => {
console.error('Error on global domain', er);
Expand Down
6 changes: 3 additions & 3 deletions benchmark/http/_chunky_http_client.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ function main({ len, n }) {
const headers = [];
// Chose 7 because 9 showed "Connection error" / "Connection closed"
// An odd number could result in a better length dispersion.
for (var i = 7; i <= 7 * 7 * 7; i *= 7)
for (let i = 7; i <= 7 * 7 * 7; i *= 7)
headers.push('o'.repeat(i));

function WriteHTTPHeaders(channel, has_keep_alive, extra_header_count) {
Expand All @@ -31,7 +31,7 @@ function main({ len, n }) {
'Chrome/39.0.2171.71 Safari/537.36');
todo.push('Accept-Encoding: gzip, deflate, sdch');
todo.push('Accept-Language: en-US,en;q=0.8');
for (var i = 0; i < extra_header_count; i++) {
for (let i = 0; i < extra_header_count; i++) {
// Utilize first three powers of a small integer for an odd cycle and
// because the fourth power of some integers overloads the server.
todo.push(`X-Header-${i}: ${headers[i % 3]}`);
Expand All @@ -41,7 +41,7 @@ function main({ len, n }) {
todo = todo.join('\r\n');
// Using odd numbers in many places may increase length coverage.
const chunksize = 37;
for (i = 0; i < todo.length; i += chunksize) {
for (let i = 0; i < todo.length; i += chunksize) {
const cur = todo.slice(i, i + chunksize);
channel.write(cur);
}
Expand Down
3 changes: 2 additions & 1 deletion benchmark/http/cluster.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ const common = require('../common.js');
const PORT = common.PORT;

const cluster = require('cluster');
let bench;
if (cluster.isMaster) {
var bench = common.createBenchmark(main, {
bench = common.createBenchmark(main, {
// Unicode confuses ab on os x.
type: ['bytes', 'buffer'],
len: [4, 1024, 102400],
Expand Down
3 changes: 2 additions & 1 deletion benchmark/napi/function_call/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ const common = require('../../common.js');
// which is quite common for benchmarks. so in that case, just
// abort quietly.

let binding;
try {
var binding = require(`./build/${common.buildType}/binding`);
binding = require(`./build/${common.buildType}/binding`);
} catch {
console.error('misc/function_call.js Binding failed to load');
process.exit(0);
Expand Down
4 changes: 2 additions & 2 deletions benchmark/util/priority-queue.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ function main({ n, type }) {
const PriorityQueue = require('internal/priority_queue');
const queue = new PriorityQueue();
bench.start();
for (var i = 0; i < n; i++)
for (let i = 0; i < n; i++)
queue.insert(Math.random() * 1e7 | 0);
for (i = 0; i < n; i++)
for (let i = 0; i < n; i++)
queue.shift();
bench.end(n);
}
4 changes: 3 additions & 1 deletion deps/openssl/config/Makefile_VC-WIN32
Original file line number Diff line number Diff line change
Expand Up @@ -5678,8 +5678,10 @@ engines/padlock-dso-e_padlock.obj: engines/padlock-dso-e_padlock.d
engines/padlock.def: util/engines.num util/mkdef.pl
$(PERL) util/mkdef.pl --ordinals util/engines.num --name padlock --OS windows > engines/padlock.def

distclean:
clean:
$(RM) $(GENERATED_MANDATORY)
$(RM) $(GENERATED)
distclean:
$(RM) configdata.pm
$(RM) makefile
$(RM) NUL
5 changes: 4 additions & 1 deletion deps/openssl/config/Makefile_VC-WIN64-ARM
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ MINOR=1.1
SHLIB_VERSION_NUMBER=1.1

GENERATED_MANDATORY=crypto/include/internal/bn_conf.h crypto/include/internal/dso_conf.h include/openssl/opensslconf.h
GENERATED=crypto/buildinf.h apps/progs.h

INSTALL_LIBS="libcrypto.lib" "libssl.lib"
INSTALL_SHLIBS="libcrypto-1_1-arm64.dll" "libssl-1_1-arm64.dll"
Expand Down Expand Up @@ -141,7 +142,9 @@ include/openssl/opensslconf.h:
"$(PERL)" "-I$(BLDDIR)" -Mconfigdata "util/dofile.pl" \
"-omakefile" "include/openssl/opensslconf.h.in" > $@

distclean:
clean:
$(RM) $(GENERATED_MANDATORY)
$(RM) $(GENERATED)
distclean:
$(RM) /Q /F configdata.pm
$(RM) /Q /F makefile
4 changes: 3 additions & 1 deletion deps/openssl/config/Makefile_VC-WIN64A
Original file line number Diff line number Diff line change
Expand Up @@ -2950,7 +2950,9 @@ engines/e_padlock.d: "engines/e_padlock.c"
engines/e_padlock.obj: engines/e_padlock.d
$(CC) $(DSO_CFLAGS) /I "include" $(DSO_CPPFLAGS) -c $(COUTFLAG)$@ "engines/e_padlock.c"

distclean:
clean:
$(RM) $(GENERATED_MANDATORY)
$(RM) $(GENERATED)
distclean:
$(RM) /Q /F configdata.pm
$(RM) /Q /F makefile
2 changes: 1 addition & 1 deletion deps/openssl/config/archs/BSD-x86_64/asm/configdata.pm
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ our %config = (
options => "enable-ssl-trace no-afalgeng no-asan no-comp no-crypto-mdebug no-crypto-mdebug-backtrace no-dynamic-engine no-ec_nistp_64_gcc_128 no-egd no-external-tests no-fuzz-afl no-fuzz-libfuzzer no-heartbeats no-md2 no-msan no-rc5 no-sctp no-shared no-ssl3 no-ssl3-method no-ubsan no-unit-test no-weak-ssl-ciphers no-zlib no-zlib-dynamic",
perl_archname => "x86_64-linux-gnu-thread-multi",
perl_cmd => "/usr/bin/perl",
perl_version => "5.26.2",
perl_version => "5.26.1",
perlargv => [ "no-comp", "no-shared", "no-afalgeng", "enable-ssl-trace", "BSD-x86_64" ],
perlenv => {
"AR" => undef,
Expand Down
2 changes: 1 addition & 1 deletion deps/openssl/config/archs/BSD-x86_64/asm/crypto/buildinf.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
*/

#define PLATFORM "platform: BSD-x86_64"
#define DATE "built on: Thu Apr 25 22:46:57 2019 UTC"
#define DATE "built on: Thu May 2 20:26:30 2019 UTC"

/*
* Generate compiler_flags as an array of individual characters. This is a
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ our %config = (
options => "enable-ssl-trace no-afalgeng no-asan no-comp no-crypto-mdebug no-crypto-mdebug-backtrace no-dynamic-engine no-ec_nistp_64_gcc_128 no-egd no-external-tests no-fuzz-afl no-fuzz-libfuzzer no-heartbeats no-md2 no-msan no-rc5 no-sctp no-shared no-ssl3 no-ssl3-method no-ubsan no-unit-test no-weak-ssl-ciphers no-zlib no-zlib-dynamic",
perl_archname => "x86_64-linux-gnu-thread-multi",
perl_cmd => "/usr/bin/perl",
perl_version => "5.26.2",
perl_version => "5.26.1",
perlargv => [ "no-comp", "no-shared", "no-afalgeng", "enable-ssl-trace", "BSD-x86_64" ],
perlenv => {
"AR" => undef,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
*/

#define PLATFORM "platform: BSD-x86_64"
#define DATE "built on: Thu Apr 25 22:47:44 2019 UTC"
#define DATE "built on: Thu May 2 20:26:36 2019 UTC"

/*
* Generate compiler_flags as an array of individual characters. This is a
Expand Down
Loading