http: call write callback even if there is no message body#27777
Closed
lpinca wants to merge 1 commit intonodejs:masterfrom
Closed
http: call write callback even if there is no message body#27777lpinca wants to merge 1 commit intonodejs:masterfrom
lpinca wants to merge 1 commit intonodejs:masterfrom
Conversation
Ensure that the callback of `OutgoingMessage.prototype.write()` is called when `outgoingMessage._hasBody` is `false` (HEAD method, 204 status code, etc.). Refs: nodejs#27709
Collaborator
lpinca
commented
May 20, 2019
| if (!msg._hasBody) { | ||
| debug('This type of response MUST NOT have a body. ' + | ||
| 'Ignoring write() calls.'); | ||
| if (callback) process.nextTick(callback); |
Member
Author
There was a problem hiding this comment.
We could replace chunk with an empty chunk and continue without bailing out, but I think it makes sense to short circuit here as all chunks are ignored.
BridgeAR
approved these changes
May 20, 2019
Member
|
Could this conceivably be a breaking change? |
Member
Author
|
I'm not sure, can't think of anything that would break. The same applies to #27709 anyway. |
Collaborator
Trott
approved these changes
Jun 1, 2019
Member
|
Landed in 2a850cd |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 1, 2019
Ensure that the callback of `OutgoingMessage.prototype.write()` is called when `outgoingMessage._hasBody` is `false` (HEAD method, 204 status code, etc.). Refs: nodejs#27709 PR-URL: nodejs#27777 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the callback of
OutgoingMessage.prototype.write()iscalled when
outgoingMessage._hasBodyisfalse(HEAD method, 204status code, etc.).
Refs: #27709
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes