Closed
Conversation
Node.js v7.10.0 did not contain N-API. Update the `introduced_in` metadata to prevent a broken 7.x "View another version" link in the N-API docs.
Collaborator
BridgeAR
approved these changes
May 17, 2019
Member
|
I wonder if we should add another optional information to skip some versions. We could also automate it by checking the release dates of each version. |
lpinca
approved these changes
May 17, 2019
Member
|
@BridgeAR I agree being able to skip versions would be good. |
mhdawson
approved these changes
May 17, 2019
Member
mhdawson
left a comment
There was a problem hiding this comment.
I hope this does not cause confusion, but with 6.x being EOL I'm willing to give it a try.
trivikr
approved these changes
May 17, 2019
Trott
approved these changes
May 17, 2019
addaleax
approved these changes
May 19, 2019
Member
addaleax
pushed a commit
that referenced
this pull request
May 19, 2019
Node.js v7.10.0 did not contain N-API. Update the `introduced_in` metadata to prevent a broken 7.x "View another version" link in the N-API docs. PR-URL: #27745 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
May 19, 2019
PR-URL: #27745 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
May 20, 2019
Node.js v7.10.0 did not contain N-API. Update the `introduced_in` metadata to prevent a broken 7.x "View another version" link in the N-API docs. PR-URL: #27745 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
May 20, 2019
PR-URL: #27745 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
introduced_inmetadataNode.js v7.10.0 did not contain N-API. Update the
introduced_inmetadata to prevent a broken 7.x "View another version" link in the
N-API docs.
The first commit ("fix

introduced_inmetadata") fixes a 404 not found link(https://nodejs.org/docs/latest-v7.x/api/n-api.html) which was disovered
in #27267 (https://travis-ci.com/nodejs/node/jobs/193473667#L1277).
As seen in the version matrix, N-API was backported to Node.js 6. I set
introduced_infor v8.0.0 based on Node.js 6 being End-of-Life andsetting to a 6.x release would still result in the broken link to 7.x due to
the simplistic way the "View another version" links are generated:
node/tools/doc/html.js
Lines 417 to 423 in f4572cc
For the version matrix the non-12.x rows of the N-API version 4 column
should be handled in #27567 (raised by a first time contributor).
cc @nodejs/n-api @nodejs/documentation
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes