meta: move jhamhader to Collaborator Emeriti list#27707
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
meta: move jhamhader to Collaborator Emeriti list#27707Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
jhamhader hasn't authored/landed/reviewed code in quite some time. I sent them an email asking about becoming Emeritus but did not get a response. It's easy enough to re-onboard someone back to active status if they become active again, so I think this is a pretty safe change to make. I'll specifically request a review of this change from them so they get notified and can comment/review/block/approve/etc. this.
Trott
added
the
meta
Collaborator
danbev
approved these changes
May 15, 2019
ZYSzys
approved these changes
May 15, 2019
Trott
added
the
author ready
benjamingr
approved these changes
May 15, 2019
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
Thank you for doing this uncomfortable but important work Rich ❤️
Member
|
And thanks for your contribution jhamhader! |
BridgeAR
approved these changes
May 15, 2019
cjihrig
approved these changes
May 15, 2019
trivikr
approved these changes
May 15, 2019
Member
|
I've pinged Yuval on a private channel and he said he is on holiday, has responded to Trott's email and will comment here when he is back from holiday :] |
Member
Author
Yuval's email was short, friendly, and said "no problem with moving to Emeriti list". I'll update the commit message on landing. |
Member
Author
|
Landed in 776e000 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 17, 2019
Yuval confirmed in email that he could be moved to Collaborator Emeritus status. PR-URL: nodejs#27707 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 17, 2019
Yuval confirmed in email that he could be moved to Collaborator Emeritus status. PR-URL: #27707 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yuval confirmed in email that it's OK to move them to the Emeriti list.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes