tools: allow RegExp in required-modules eslint rule#27647
Merged
richardlau merged 1 commit intonodejs:masterfrom May 13, 2019
Merged
tools: allow RegExp in required-modules eslint rule#27647richardlau merged 1 commit intonodejs:masterfrom
richardlau merged 1 commit intonodejs:masterfrom
Conversation
Collaborator
Collaborator
Trott
approved these changes
May 11, 2019
Trott
added
the
author ready
targos
approved these changes
May 11, 2019
BridgeAR
approved these changes
May 13, 2019
richardlau
force-pushed
the
eslint-required-modules-regexp
branch
from
3e6983a to
45a4230
Compare
Collaborator
Collaborator
PR-URL: nodejs#27647 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
richardlau
force-pushed
the
eslint-required-modules-regexp
branch
from
45a4230 to
1df3080
Compare
Member
Author
|
Landed in 1df3080. |
targos
pushed a commit
that referenced
this pull request
May 14, 2019
PR-URL: #27647 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #27545 (review)
The fixup commit is to tidy up the error message when the lint rule fails (kept
separate here for ease of reviewing) and should be autosquashed on landing.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes