doc,meta: codify security release commit message#27643
Closed
richardlau wants to merge 1 commit intonodejs:masterfrom
Closed
doc,meta: codify security release commit message#27643richardlau wants to merge 1 commit intonodejs:masterfrom
richardlau wants to merge 1 commit intonodejs:masterfrom
Conversation
The release commit message for security releases have conventionally started with the phrase `This is a security release.`. Codify this as part of the release process so that the distribution indexer can use this to detect and mark releases as security releases. Fixes: nodejs/Release#437 Refs: nodejs#27612 (comment) Refs: nodejs/nodejs-dist-indexer#9
Collaborator
sam-github
approved these changes
May 10, 2019
This was referenced May 10, 2019
BethGriggs
approved these changes
May 10, 2019
fhinkel
approved these changes
May 11, 2019
antsmartian
approved these changes
May 11, 2019
cjihrig
approved these changes
May 11, 2019
jasnell
approved these changes
May 12, 2019
BridgeAR
approved these changes
May 13, 2019
BridgeAR
added
the
author ready
Trott
approved these changes
May 13, 2019
Member
|
Landed in b3be0bf |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 13, 2019
The release commit message for security releases have conventionally started with the phrase `This is a security release.`. Codify this as part of the release process so that the distribution indexer can use this to detect and mark releases as security releases. Fixes: nodejs/Release#437 Refs: nodejs#27612 (comment) Refs: nodejs/nodejs-dist-indexer#9 PR-URL: nodejs#27643 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 14, 2019
The release commit message for security releases have conventionally started with the phrase `This is a security release.`. Codify this as part of the release process so that the distribution indexer can use this to detect and mark releases as security releases. Fixes: nodejs/Release#437 Refs: #27612 (comment) Refs: nodejs/nodejs-dist-indexer#9 PR-URL: #27643 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release commit message for security releases have conventionally
started with the phrase
This is a security release.. Codify thisas part of the release process so that the distribution indexer can
use this to detect and mark releases as security releases.
Fixes: nodejs/Release#437
Refs: #27612 (comment)
Refs: nodejs/nodejs-dist-indexer#9
cc @nodejs/security-wg (as the requirement came out of one of their meetings)
@nodejs/security-release (this should just be a case of writing down what already happens)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes