assert,test: complete coverage for AssertionError#27635
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
assert,test: complete coverage for AssertionError#27635Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
There were two code branches in lib/internal/assert/assertion_error.js that were not covered by tests. This adds a test to cover the two uncovered branches. The test revealed that there was some missing properties/functaionality in the AssertionError class. So this also adds the missing material.
Collaborator
nodejs-github-bot
added
the
assert
Collaborator
Collaborator
BridgeAR
reviewed
May 10, 2019
Member
There was a problem hiding this comment.
I removed those because they are not used by assert. The operator is == and != for these two cases. We do expose AssertionError but this is not documented and I believe we should consider that an implementation detail.
Instead, it would be better to fix the conditions to match the correct operator.
jasnell
approved these changes
May 10, 2019
Member
Author
|
Closing in favor of #27676 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two code branches in lib/internal/assert/assertion_error.js
that were not covered by tests. This adds a test to cover the
two uncovered branches. The test revealed that there was some missing
properties/functaionality in the AssertionError class. So this also adds
the missing material.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes