tools: fix use-after-free mkcodecache warning #27332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call `v8::Platform::ShutdownPlatform()` to fix a Coverity warning about the `v8::Platform` instance being deleted when it's still in use.
joyeecheung
approved these changes
Apr 21, 2019
richardlau
approved these changes
Apr 21, 2019
BridgeAR
added
the
author ready
cjihrig
approved these changes
Apr 21, 2019
|
Landed in a88700a. |
danbev
pushed a commit
that referenced
this pull request
Apr 24, 2019
Call `v8::Platform::ShutdownPlatform()` to fix a Coverity warning about the `v8::Platform` instance being deleted when it's still in use. PR-URL: #27332 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 27, 2019
Call `v8::Platform::ShutdownPlatform()` to fix a Coverity warning about the `v8::Platform` instance being deleted when it's still in use. PR-URL: #27332 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call
v8::Platform::ShutdownPlatform()to fix a Coverity warning aboutthe
v8::Platforminstance being deleted when it's still in use.