Skip to content

Conversation

@gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Apr 17, 2019

Found by https://ci.nodejs.org/job/node-clang-tidy/7/console.

cc @refack

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 17, 2019
@gengjiawen gengjiawen force-pushed the deprecated_headers branch 2 times, most recently from 742af1b to 9884287 Compare April 17, 2019 15:53
@gengjiawen gengjiawen changed the title src: apply clang-tidy modernize-deprecated-headers found by Jenkins CI. src: apply clang-tidy modernize-deprecated-headers found by Jenkins CI Apr 17, 2019
@nodejs-github-bot
Copy link
Collaborator

@gengjiawen
Copy link
Member Author

@addaleax @refack Can you review this ? Thanks.

@nodejs-github-bot
Copy link
Collaborator

@gengjiawen
Copy link
Member Author

@danbev Can you merge this ? Thanks.

@danbev
Copy link
Contributor

danbev commented Apr 26, 2019

Landed in 5fe4d59.

@danbev danbev closed this Apr 26, 2019
danbev pushed a commit that referenced this pull request Apr 26, 2019
PR-URL: #27279
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Apr 27, 2019
PR-URL: #27279
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants