Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: apply clang-tidy rule modernize-use-equals-default #27264

Merged
merged 1 commit into from
Apr 24, 2019
Merged

src: apply clang-tidy rule modernize-use-equals-default #27264

merged 1 commit into from
Apr 24, 2019

Conversation

gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Apr 16, 2019 •
edited
Loading

Also from: https://ci.nodejs.org/job/node-clang-tidy/7/console.
Rule def: https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-equals-default.html.

cc @refack

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Apr 16, 2019
@gengjiawen gengjiawen force-pushed the clang-tidy-modernize-use-equals-default branch from 718ebce to d4b8961 Compare April 17, 2019 15:03
@gengjiawen
Copy link
Member Author

@addaleax @refack Can you review this ? Thanks.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22525/

addaleax
addaleax reviewed Apr 17, 2019
View reviewed changes
src/fs_event_wrap.cc Outdated Show resolved Hide resolved
src/tracing/traced_value.cc Outdated Show resolved Hide resolved
src/spawn_sync.cc Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22532/

@gengjiawen gengjiawen force-pushed the clang-tidy-modernize-use-equals-default branch from d4b8961 to 38a817a Compare April 18, 2019 13:16
This was referenced Apr 20, 2019
Closed
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22676/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22687/

@gengjiawen @refack
src: apply clang-tidy rule modernize-use-equals-default
51079db 
PR-URL: nodejs#27264
Reviewed-By: Refael Ackermann <refack@gmail.com>
@refack refack force-pushed the clang-tidy-modernize-use-equals-default branch from 38a817a to 51079db Compare April 24, 2019 17:33
@refack refack merged commit 51079db into nodejs:master Apr 24, 2019
targos pushed a commit that referenced this pull request Apr 27, 2019
@gengjiawen @targos
src: apply clang-tidy rule modernize-use-equals-default
7bc47cb 
PR-URL: #27264
Reviewed-By: Refael Ackermann <refack@gmail.com>
@targos targos mentioned this pull request Apr 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax left review comments

@refack refack refack approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gengjiawen @nodejs-github-bot @refack @addaleax