test: add ability to skip common flag checks#27254
Closed
addaleax wants to merge 2 commits intonodejs:masterfrom
Closed
test: add ability to skip common flag checks#27254addaleax wants to merge 2 commits intonodejs:masterfrom
addaleax wants to merge 2 commits intonodejs:masterfrom
Conversation
Currently, `common/index.js` checks that our test files are spawned with the flags specified in `// Flags:`, and re-spawns with them if they are not found. This can be *very* annoying, for example when debugging using debuggers that attach to the parent process, or when intentionally testing with flags that are different from the specified ones. This adds a `NODE_SKIP_FLAG_CHECK` environment variable check. Setting it to a non-empty value will skip the flag checks altogether.
Collaborator
BridgeAR
approved these changes
Apr 16, 2019
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
LGTM. Maybe even add a comment about the env in the comment that the process is spawned as child?
Member
Author
@BridgeAR Done, PTAL |
Member
|
Still LGTM. Thanks for adding the comment. |
BethGriggs
approved these changes
Apr 16, 2019
cjihrig
approved these changes
Apr 16, 2019
addaleax
added
the
author ready
Collaborator
jasnell
approved these changes
Apr 16, 2019
lpinca
approved these changes
Apr 16, 2019
hiroppy
approved these changes
Apr 16, 2019
antsmartian
approved these changes
Apr 17, 2019
Collaborator
Member
|
Landed in 02885da 🎉 |
ZYSzys
pushed a commit
that referenced
this pull request
Apr 19, 2019
Currently, `common/index.js` checks that our test files are spawned with the flags specified in `// Flags:`, and re-spawns with them if they are not found. This can be *very* annoying, for example when debugging using debuggers that attach to the parent process, or when intentionally testing with flags that are different from the specified ones. This adds a `NODE_SKIP_FLAG_CHECK` environment variable check. Setting it to a non-empty value will skip the flag checks altogether. PR-URL: #27254 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
common/index.jschecks that our test files arespawned with the flags specified in
// Flags:, and re-spawnswith them if they are not found.
This can be very annoying, for example when debugging using
debuggers that attach to the parent process, or when intentionally
testing with flags that are different from the specified ones.
This adds a
NODE_SKIP_FLAG_CHECKenvironment variable check.Setting it to a non-empty value will skip the flag checks altogether.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes