Skip to content

test: do not strip left whitespace in pseudo-tty tests #27244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test: do not strip left whitespace in pseudo-tty tests #27244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/pseudo-tty/console_colors.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ string q
{ foo: *[32m'bar'*[39m } with object format param

Error: test
at abc (../fixtures/node_modules/bar.js:4:4)
at abc (../fixtures/node_modules/bar.js:4:4)
foobar
at * (*console_colors.js:*:*)
at * (*console_colors.js:*:*)
*[90m at * (internal*:*:*)*[39m
*[90m at *[39m
*[90m at *[39m
Expand All @@ -14,22 +14,22 @@ at * (*console_colors.js:*:*)
*[90m at *[39m

Error: Should not ever get here.
at * (*node_modules*[4m*node_modules*[24m*bar.js:*:*)
at * (*node_modules*[4m*node_modules*[24m*bar.js:*:*)
*[90m at *[39m
*[90m at *[39m
*[90m at *[39m
*[90m at *[39m
*[90m at *[39m
*[90m at *[39m
at * (*console_colors.js:*:*)
at * (*console_colors.js:*:*)
*[90m at *[39m
*[90m at *[39m

Error
at evalmachine.<anonymous>:*:*
at evalmachine.<anonymous>:*:*
*[90m at Script.runInThisContext (vm.js:*:*)*[39m
*[90m at Object.runInThisContext (vm.js:*:*)*[39m
at * (*console_colors.js:*:*)
at * (*console_colors.js:*:*)
*[90m at *[39m
*[90m at *[39m
*[90m at *[39m
Expand Down
2 changes: 1 addition & 1 deletion test/pseudo-tty/testcfg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def IsFailureOutput(self, output):
patterns.append(pattern)
# Compare actual output with the expected
raw_lines = (output.stdout + output.stderr).split('\n')
outlines = [ s.strip() for s in raw_lines if not self.IgnoreLine(s) ]
outlines = [ s.rstrip() for s in raw_lines if not self.IgnoreLine(s) ]
if len(outlines) != len(patterns):
print("length differs.")
print("expect=%d" % len(patterns))
Expand Down