tools: update js-yaml to 3.13.1 for lint-md.js #27195
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update js-yaml from 3.13.0 to 3.13.1 in the lint-md.js tool. Version 3.13.0 is the subject of a security problem. It is almost certainly not anything that is reasonable exploitable in our code base (as it's internal tooling) but good to update anyway just in case... Refs: https://app.snyk.io/vuln/SNYK-JS-JSYAML-174129
Collaborator
Trott
added
the
author ready
mihalskiy
approved these changes
Apr 12, 2019
Member
Author
|
Landed in d4e7431 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 14, 2019
Update js-yaml from 3.13.0 to 3.13.1 in the lint-md.js tool. Version 3.13.0 is the subject of a security problem. It is almost certainly not anything that is reasonable exploitable in our code base (as it's internal tooling) but good to update anyway just in case... Refs: https://app.snyk.io/vuln/SNYK-JS-JSYAML-174129 PR-URL: nodejs#27195 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update js-yaml from 3.13.0 to 3.13.1 in the lint-md.js tool. Version
3.13.0 is the subject of a security problem. It is almost certainly not
anything that is reasonable exploitable in our code base (as it's
internal tooling) but good to update anyway just in case...
Refs: https://app.snyk.io/vuln/SNYK-JS-JSYAML-174129
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes