Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: replace FromJust() with Check() when possible #27162

Closed
wants to merge 3 commits into from
Closed

src: replace FromJust() with Check() when possible #27162

wants to merge 3 commits into from
+339 −340

Commits on Apr 11, 2019

  1. src: replace FromJust() with Check() when possible 

    FromJust() is often used not for its return value, but for its
side-effects. In these cases, Check() exists, and is more clear as to
the intent. From its comment:

  To be used, where the actual value of the Maybe is not needed like
  Object::Set.

See: https://github.com/nodejs/node/pull/26929/files#r269256335
    @sam-github
    sam-github committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    f974f1e View commit details
    Browse the repository at this point in the history

  2. fixup! src: replace FromJust() with Check() when possible

    @sam-github
    sam-github committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    f281035 View commit details
    Browse the repository at this point in the history

  3. fixup! fixup! src: replace FromJust() with Check() when possible

    @sam-github
    sam-github committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    9a6d74e View commit details
    Browse the repository at this point in the history