doc: add missing n-api version indicator#27155
Closed
mhdawson wants to merge 1 commit intonodejs:masterfrom
Closed
doc: add missing n-api version indicator#27155mhdawson wants to merge 1 commit intonodejs:masterfrom
mhdawson wants to merge 1 commit intonodejs:masterfrom
Conversation
When the threadsafe functions were promoted to version 4 from experimental we missed documenting that. Add the version indicator for these functions in the doc.
Collaborator
nodejs-github-bot
added
doc
cjihrig
approved these changes
Apr 9, 2019
richardlau
approved these changes
Apr 9, 2019
jasnell
approved these changes
Apr 10, 2019
richardlau
added
the
author ready
Member
Author
|
Landed in |
mhdawson
added a commit
that referenced
this pull request
Apr 11, 2019
When the threadsafe functions were promoted to version 4 from experimental we missed documenting that. Add the version indicator for these functions in the doc. PR-URL: #27155 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the threadsafe functions were promoted to
version 4 from experimental we missed documenting
that. Add the version indicator for these functions
in the doc.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes