cli: implement --cpu-prof[-path]#27147
Closed
joyeecheung wants to merge 3 commits intonodejs:masterfrom
Closed
Conversation
This patch introduces a CLI flag --cpu-prof that starts the V8
CPU profiler on start up, and ends the profiler then writes the
CPU profile before the Node.js instance (on the main thread or
the worker thread) exits. By default the profile is written to
`${cwd}/CPU.${yyyymmdd}.${hhmmss}.${pid}.${tid}.${seq}.cpuprofile`.
The patch also introduces a --cpu-prof-path flag for the user
to specify the path the profile will be written to.
Fixes: nodejs#26878
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
c++
This comment has been minimized.
This comment has been minimized.
Contributor
|
I don't see where the filename is being formatted as described (like it is for the coverage reports)? |
This comment has been minimized.
This comment has been minimized.
joyeecheung
commented
Apr 9, 2019
| // TODO(joyeecheung): fallback to exec path / argv[0] | ||
| CHECK_EQ(err, 0); | ||
| CHECK_GT(size, 0); | ||
| DiagnosticFilename filename(env, "CPU", "cpuprofile"); |
Member
Author
This comment has been minimized.
This comment has been minimized.
addaleax
approved these changes
Apr 9, 2019
joyeecheung
added
semver-minor
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
joyeecheung
added
the
author ready
Member
Author
|
If there are no more questions I am going to land this on Friday. |
Member
Author
|
Landed in e0e3084 |
joyeecheung
removed
the
author ready
joyeecheung
added a commit
that referenced
this pull request
Apr 19, 2019
This patch introduces a CLI flag --cpu-prof that starts the V8
CPU profiler on start up, and ends the profiler then writes the
CPU profile before the Node.js instance (on the main thread or
the worker thread) exits. By default the profile is written to
`${cwd}/CPU.${yyyymmdd}.${hhmmss}.${pid}.${tid}.${seq}.cpuprofile`.
The patch also introduces a --cpu-prof-path flag for the user
to specify the path the profile will be written to.
Refs: #26878
PR-URL: #27147
Reviewed-By: Anna Henningsen <anna@addaleax.net>
4 tasks
Member
|
we've added support for this in 0x https://github.com/davidmarkclements/0x#--visualize-cpu-profile |
This was referenced Apr 23, 2019
This was referenced Jan 12, 2022
This was referenced Feb 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces a CLI flag --cpu-prof that starts the V8
CPU profiler on start up, and ends the profiler then writes the
CPU profile before the Node.js instance (on the main thread or
the worker thread) exits. By default the profile is written to
${cwd}/CPU.${yyyymmdd}.${hhmmss}.${pid}.${tid}.${seq}.cpuprofile.The patch also introduces a --cpu-prof-path flag for the user
to specify the path the profile will be written to.
Fixes: #26878
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes