Skip to content

lib,report: improve signal name validation #27137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2019
Merged

lib,report: improve signal name validation #27137

merged 2 commits into from
Apr 11, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Apr 8, 2019

  • Add a signal name validator to enforce type and check for known signals.
  • Improve error message when the signal name casing is incorrect.
  • Use the new validator in the report module.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3200

@nodejs-github-bot nodejs-github-bot added the process Issues and PRs related to the process subsystem. label Apr 8, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22284/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 9, 2019 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/22286/

EDIT(cjihrig): 💚

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 9, 2019
cjihrig added 2 commits April 10, 2019 20:35
@cjihrig
lib: add signal name validator
5b9e570 
PR-URL: nodejs#27137
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@cjihrig
report: improve signal name validation
44a3acb 
PR-URL: nodejs#27137
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@cjihrig
Copy link
Contributor Author

cjihrig commented Apr 11, 2019

Landed in 72f4a83...44a3acb. Thanks for the reviews.

@cjihrig cjihrig closed this Apr 11, 2019
@cjihrig cjihrig deleted the signal-validate branch April 11, 2019 00:37
@cjihrig cjihrig merged commit 44a3acb into nodejs:master Apr 11, 2019
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+1 more reviewer

@Fishrock123 Fishrock123 Fishrock123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cjihrig @nodejs-github-bot @bnoordhuis @Fishrock123 @richardlau @BridgeAR