src: use SealHandleScope for inspector tasks#27116
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
src: use SealHandleScope for inspector tasks#27116addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
This addresses a TODO comment that can be resolved, now that we have V8 7.4.
Collaborator
nodejs-github-bot
added
the
c++
jasnell
approved these changes
Apr 8, 2019
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
LGTM.
Side note: it would be useful to document somewhere when it is appropriate to use each of these.
Collaborator
joyeecheung
approved these changes
Apr 9, 2019
BridgeAR
added
the
author ready
Collaborator
Collaborator
danbev
approved these changes
Apr 10, 2019
Contributor
|
Landed in c1e03ed. |
danbev
pushed a commit
that referenced
this pull request
Apr 10, 2019
This addresses a TODO comment that can be resolved, now that we have V8 7.4. PR-URL: #27116 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a TODO comment that can be resolved,
now that we have V8 7.4.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes