lib: force using primordials for JSON, Math and Reflect #27027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the "no-restricted-globals" ESLint rule to lint for it.
nodejs-github-bot
added
the
lib / src
targos
added
the
semver-major
addaleax
approved these changes
Mar 31, 2019
joyeecheung
approved these changes
Mar 31, 2019
|
I don’t think we have to make this semver-major? Monkey patching JS builtins is not something we provide any stability guarantees for? |
cjihrig
approved these changes
Mar 31, 2019
BridgeAR
approved these changes
Mar 31, 2019
BridgeAR
added
the
author ready
devsnek
approved these changes
Mar 31, 2019
targos
removed
the
semver-major
|
Should we also do safemap and safeset? |
|
@MylesBorins |
lpinca
approved these changes
Apr 1, 2019
This was referenced Apr 2, 2019
|
Landed in 0817840 🎉 |
ZYSzys
pushed a commit
that referenced
this pull request
Apr 3, 2019
Use the "no-restricted-globals" ESLint rule to lint for it. PR-URL: #27027 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 4, 2019
Use the "no-restricted-globals" ESLint rule to lint for it. PR-URL: #27027 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Apr 23, 2019
This was referenced Apr 23, 2019
MarshallOfSound
pushed a commit
to electron/node
that referenced
this pull request
Jun 26, 2019
Use the "no-restricted-globals" ESLint rule to lint for it. PR-URL: nodejs/node#27027 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the "no-restricted-globals" ESLint rule to lint for it.