Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix test.py --time #27007

Merged
merged 1 commit into from
Apr 2, 2019
Merged

tools: fix test.py --time #27007

merged 1 commit into from
Apr 2, 2019

Conversation

richardlau
Copy link
Member

Before:

-bash-4.2$ ./tools/test.py --time doctool
[00:02|% 100|+   4|-   0]: Done

--- Total time: 00:02.770 ---
Traceback (most recent call last):
  File "./tools/test.py", line 1765, in <module>
    sys.exit(Main())
  File "./tools/test.py", line 1758, in Main
    t = FormatTimedelta(entry.duration)
  File "./tools/test.py", line 1514, in FormatTimedelta
    if hasattr(td.total, 'total_seconds'):
AttributeError: 'datetime.timedelta' object has no attribute 'total'
-bash-4.2$

After:

-bash-4.2$ ./tools/test.py --time doctool
[00:02|% 100|+   4|-   0]: Done

--- Total time: 00:02.905 ---
   1 (00:01.612) release test-apilinks
   2 (00:00.710) release test-doctool-html
   3 (00:00.411) release test-doctool-json
   4 (00:00.171) release test-make-doc
-bash-4.2$
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3102/pipeline

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Mar 30, 2019
@richardlau
Copy link
Member Author

test.py --time was broken by ec4f70e.

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 30, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22028/

@targos
Copy link
Member

targos commented Mar 30, 2019

TIL about the --time option 😄

@richardlau
tools: fix test.py --time
8bfce89 
PR-URL: nodejs#27007
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@richardlau
Copy link
Member Author

Landed in 8bfce89.

@richardlau richardlau merged commit 8bfce89 into nodejs:master Apr 2, 2019
@richardlau richardlau deleted the fixtestpytime branch April 2, 2019 12:39
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@richardlau @BethGriggs
tools: fix test.py --time
4027aff 
PR-URL: #27007
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@richardlau @BethGriggs
tools: fix test.py --time
41653c6 
PR-URL: #27007
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@richardlau @BethGriggs
tools: fix test.py --time
3ff3070 
PR-URL: #27007
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 10, 2019
@richardlau @BethGriggs
tools: fix test.py --time
5945cf0 
PR-URL: #27007
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@richardlau @nodejs-github-bot @targos @refack @lpinca @cjihrig @BridgeAR @ZYSzys