util: improve util inspect output#26984
Closed
BridgeAR wants to merge 3 commits intonodejs:masterfrom
Closed
Conversation
This fixes a proportion calculation for lots of short array entries with at least one bigger one that alone makes up for more than one fifth of all other entries together.
This makes sure that errors that contain extra properties show those properties on a separate line.
Collaborator
|
@BridgeAR Sadly, an error occurred when I tried to trigger a build. :( |
targos
approved these changes
Mar 29, 2019
Member
Author
|
I just pushed one small commit that adds one more check to prevent unnecessary work in the default case (but no changed behavior). |
Collaborator
Collaborator
Member
|
Can you please explain how this improves the output? |
Member
Author
|
@mcollina did you see the commit messages? Without the first commit the corresponding test would just create a single Without the second commit the corresponding tests would not add a linebreak const err = new Error();
err.foo = true;
console.log(err);
// Only the last line:
// Before
// at REPLServer.Interface._line (readline.js:675:8) foo: true }
// Now
// at REPLServer.Interface._line (readline.js:675:8)
// foo: true } |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Apr 3, 2019
This fixes a proportion calculation for lots of short array entries with at least one bigger one that alone makes up for more than one fifth of all other entries together. PR-URL: nodejs#26984 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Apr 3, 2019
This makes sure that errors that contain extra properties show those properties on a separate line. PR-URL: nodejs#26984 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Member
Author
BethGriggs
pushed a commit
that referenced
this pull request
Apr 4, 2019
This fixes a proportion calculation for lots of short array entries with at least one bigger one that alone makes up for more than one fifth of all other entries together. PR-URL: #26984 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 4, 2019
This makes sure that errors that contain extra properties show those properties on a separate line. PR-URL: #26984 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This was referenced Apr 23, 2019
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please have a look at the commit messages for details.
@nodejs/util PTAL
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes