test: simplify date inspection tests #26922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code duplicated a lot of logic that was already abstracted. Use the abstraction instead to remove code overhead.
BridgeAR
force-pushed
the
simplify-inspect-tests
branch
from
14279b1
to
27bbd74
Compare
|
Rebased due to conflicts. @nodejs/testing PTAL |
targos
approved these changes
Mar 29, 2019
BridgeAR
added
the
author ready
|
@nodejs/testing |
|
CI: https://ci.nodejs.org/job/node-test-pull-request/22035/ ✅ (yellow build) |
antsmartian
approved these changes
Apr 2, 2019
|
Landed in 666c67e. |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Apr 3, 2019
The code duplicated a lot of logic that was already abstracted. Use the abstraction instead to remove code overhead. PR-URL: nodejs#26922 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 5, 2019
The code duplicated a lot of logic that was already abstracted. Use the abstraction instead to remove code overhead. PR-URL: #26922 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code duplicated a lot of logic that was already abstracted. Use
the abstraction instead to remove code overhead.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes