tools: update capitalized-comments eslint rule#26849
tools: update capitalized-comments eslint rule#26849BridgeAR wants to merge 6 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
http
test/parallel/test-repl.js
Outdated
There was a problem hiding this comment.
I kind of chafe at markdown in comments, so this is (from my perspective) mildly unfortunate. Not blocking--only commenting in case you have another idea. (Maybe we can just add |npm to the end of the ignorePatterns regexp? Maybe long-term goal can be that the whole regexp will just be a set of words separated by pipe characters like var|let|const|npm?
There was a problem hiding this comment.
We could add a couple of words to the blacklist but I guess it might become relatively big if we only use a blacklist. So I would definitely keep the current ignore pattern as it overall worked very well.
There was a problem hiding this comment.
Hm, I personally would say this specific case actually benefits by making clear that npm is something specific. If it would be a more generic word, it would be difficult to distinguish it from the rest of the comment.
BridgeAR
force-pushed
the
stricter-capitalize-comments
branch
from
fbb4308 to
665055d
Compare
|
Rebased due to conflicts. I incorporated all feedback in the "fixup" commits. PTAL.
|
BridgeAR
added
the
author ready
This strictens the rule to apply from 20 characters on instead of from 30.
Address comments
BridgeAR
force-pushed
the
stricter-capitalize-comments
branch
from
443f712 to
3de5713
Compare
|
Rebased due to conflicts. Lite CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3035/ |
PR-URL: nodejs#26849 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This strictens the rule to apply from 20 characters on instead of from 30. PR-URL: nodejs#26849 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
PR-URL: #26849 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This strictens the rule to apply from 20 characters on instead of from 30. PR-URL: #26849 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
5 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes