Skip to content

process: remove usage of require('util') in per_thread.js #26817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

process: remove usage of require('util') in per_thread.js #26817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/internal/process/per_thread.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const {
ERR_UNKNOWN_SIGNAL
}
} = require('internal/errors');
const util = require('util');
const format = require('internal/util/inspect').format;
Copy link
Member

@jasnell jasnell Mar 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const format = require('internal/util/inspect').format;
const { format } = require('internal/util/inspect');

const constants = internalBinding('constants').os.signals;

function assert(x, msg) {
Expand All @@ -32,7 +32,7 @@ function wrapProcessMethods(binding) {
} = binding;

function _rawDebug(...args) {
binding._rawDebug(util.format.apply(null, args));
binding._rawDebug(format.apply(null, args));
}

// Create the argument array that will be passed to the native function.
Expand Down