src: guard exit label when inspector disabled #26801
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when configured --without-inspector the following warning will be generated: ../src/node.cc:859:1: warning: unused label 'exit' [-Wunused-label] exit: This commit adds a guard to exclude the label when there is no inspector support.
nodejs-github-bot
added
the
c++
richardlau
approved these changes
Mar 21, 2019
jasnell
approved these changes
Mar 21, 2019
cjihrig
approved these changes
Mar 22, 2019
|
Re-run of failing node-test-commit-windows-fanned (✔️) |
ZYSzys
approved these changes
Mar 22, 2019
|
Landed in cdb87d9. |
danbev
added a commit
that referenced
this pull request
Mar 25, 2019
Currently, when configured --without-inspector the following warning will be generated: ../src/node.cc:859:1: warning: unused label 'exit' [-Wunused-label] exit: This commit adds a guard to exclude the label when there is no inspector support. PR-URL: #26801 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
Currently, when configured --without-inspector the following warning will be generated: ../src/node.cc:859:1: warning: unused label 'exit' [-Wunused-label] exit: This commit adds a guard to exclude the label when there is no inspector support. PR-URL: nodejs#26801 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
Currently, when configured --without-inspector the following warning will be generated: ../src/node.cc:859:1: warning: unused label 'exit' [-Wunused-label] exit: This commit adds a guard to exclude the label when there is no inspector support. PR-URL: #26801 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when configured
--without-inspectorthe following warningwill be generated:
This commit adds a guard to exclude the label when there is no
inspector support.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes