test: marking recent test failures as flaky #2679
Conversation
v8 will silently return an empty handle which doesn't delete our data if string length is above String::kMaxLength Fixes: nodejs#1374 PR-URL: nodejs#2402 Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Add an optional callback parameter to `ChildProcess.prototype.send()` that is invoked when the message has been sent. Juggle the control channel's reference count so that in-flight messages keep the event loop (and therefore the process) alive until they have been sent. `ChildProcess.prototype.send()` and `process.send()` used to operate synchronously but became asynchronous in commit libuv/libuv@393c1c5 ("unix: set non-block mode in uv_{pipe,tcp,udp}_open"), which landed in io.js in commit 07bd05b ("deps: update libuv to 1.2.1"). Fixes: nodejs#760 PR-URL: nodejs#2620 Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com> Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
This test has failed recently during a PR test in Jenkins, for reasons seemingly not related to the change in the PR. PR-URL: nodejs#2648 Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com>
Fixes: nodejs#1972 PR-URL: nodejs#2322 Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
joaocgreis
added
build
joaocgreis
force-pushed
the
joaocgreis-F93-flaky-tests
branch
from
44b72a1
to
46796ae
Compare
| test-http-set-timeout : PASS,FLAKY | ||
| test-net-listen-shared-ports : PASS,FLAKY | ||
| test-net-server-max-connections : PASS,FLAKY | ||
| test-stringbytes-external : PASS,FLAKY |
There was a problem hiding this comment.
This was fixed in 37ee43e
There was a problem hiding this comment.
That landed 2d ago but I got it from a run 7h ago. Just updated the sources in the test above, sorry for the delay. I'll start filing issues, I'll include this info. Thanks!
|
LGTM |
joaocgreis
force-pushed
the
joaocgreis-F93-flaky-tests
branch
from
46796ae
to
a712cfc
Compare
These tests failed in either master builds, unrelated changes (like marking tests as flaky) or are properly discussed in the respective pull requests.
joaocgreis
force-pushed
the
joaocgreis-F93-flaky-tests
branch
from
a712cfc
to
deea530
Compare
|
Added Added |
|
LGTM. I saw those tests fail in a PR that was only updating flaky tests :( |
|
References for the update made above:
|
|
This makes me sad but no other option as of now ¯_(ツ)_/¯ So LGTM. |
|
Wasn't |
|
@evanlucas Yes, now I know. And the same for Since |
|
This will be revisited soon, probably as a shiny new PR. For now it doesn't make much sense to keep this open. |
These tests failed in either master builds, unrelated changes (like marking tests as flaky) or are properly discussed in the respective pull requests.
test-tick-processor: build: Add build-with-asan + use leak-check before v8 teardown #2376 (comment)test-regress-GH-877: https://ci.nodejs.org/job/node-test-commit-other/411/nodes=smartos14-32/tapTestReport/test.tap-894/test-net-listen-shared-ports: https://ci.nodejs.org/job/node-test-commit-arm/458/nodes=armv7-wheezy/tapTestReport/test.tap-501/test-dgram-udp4: https://ci.nodejs.org/job/node-test-commit-arm/459/nodes=pi1-raspbian-wheezy-1_of_2/tapTestReport/test.tap-83/test-http-set-timeout: https://ci.nodejs.org/job/node-test-commit-linux/431/nodes=centos7-64/tapTestReport/test.tap-395/test-cluster-disconnect: https://ci.nodejs.org/job/node-test-commit-arm/464/nodes=pi1-raspbian-wheezy-1_of_2/tapTestReport/test.tap-38/test-sigint-infinite-loop: https://ci.nodejs.org/job/node-test-commit-arm/469/nodes=armv7-wheezy/tapTestReport/test.tap-904/test-child-process-fork-dgram,test-cluster-dgram-1.js,test-cluster-dgram-2,test-dgram-bind-default-address,test-dgram-bind-shared-ports,test-dgram-empty-packet,test-dgram-exclusive-implicit-bind,test-dgram-implicit-bind,test-dgram-multicast-setTTL,test-dgram-pingpong: https://ci.nodejs.org/job/node-test-commit-linux/448/nodes=centos5-64/consoletest-stringbytes-external: https://ci.nodejs.org/job/node-test-commit-arm/474/nodes=pi1-raspbian-wheezy-2_of_2/tapTestReport/test.tap-336/test-stdout-stderr-reading: https://ci.nodejs.org/job/node-test-commit-arm/474/nodes=armv7-wheezy/tapTestReport/test.tap-907/test-process-config: https://ci.nodejs.org/job/node-test-commit-windows/469/nodes=win2012r2/tapTestReport/test.tap-551/test-repl-tab-complete: https://ci.nodejs.org/job/node-test-commit-windows/469/nodes=win2012r2/tapTestReport/test.tap-602/test-child-process-fork-net2: test: test-child-process-fork-net2 is flaky #2670 also for Windows: https://ci.nodejs.org/job/node-test-commit-windows/460/nodes=win2012r2/tapTestReport/test.tap-36/test-child-process-emfile: test: test-child-process-emfile is flaky #2671test-net-server-max-connections: test: mark test-net-server-max-connections as flaky #2664Replaces #2664 , #2670 and #2671
cc @nodejs/build