Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use explicit casts to silence conversion warnings #26766

Closed
wants to merge 1 commit into from
Closed

src: use explicit casts to silence conversion warnings #26766

wants to merge 1 commit into from

Conversation

zbjornson
Copy link
Contributor

Addresses ~30 of the warnings posted in #26733 (comment). (I don't think there's a better solution than accepting the precision loss, since bigint is already an available option.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Mar 19, 2019
@Trott
Copy link
Member

Trott commented Mar 19, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21654/

@danbev
Copy link
Contributor

danbev commented Mar 22, 2019

Landed in 0b516fa.

@danbev danbev closed this Mar 22, 2019
danbev pushed a commit that referenced this pull request Mar 22, 2019
@zbjornson @danbev
src: use explicit casts to silence conversion warnings
0b516fa 
PR-URL: #26766
Ref #26733
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@zbjornson @targos
src: use explicit casts to silence conversion warnings
d00b8ae 
PR-URL: nodejs#26766
Ref nodejs#26733
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@zbjornson @targos
src: use explicit casts to silence conversion warnings
6911678 
PR-URL: #26766
Ref #26733
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JungMinu JungMinu JungMinu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@zbjornson @Trott @danbev @bnoordhuis @addaleax @cjihrig @JungMinu @nodejs-github-bot