Skip to content

src,win: fix usage of deprecated v8::Object::Set #26735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2019
Merged

src,win: fix usage of deprecated v8::Object::Set #26735

merged 1 commit into from
Mar 18, 2019

Conversation

@targos
Copy link
Member

@targos targos commented Mar 18, 2019

Refs: #26733

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 18, 2019

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2961/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 18, 2019
@targos
Copy link
Member Author

targos commented Mar 18, 2019

@refack

@targos
Copy link
Member Author

targos commented Mar 18, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21623/

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 18, 2019
@refack refack added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 18, 2019
@refack
Copy link
Contributor

refack commented Mar 18, 2019

This is pure win, so I move for fast-tacking. Please 👍 this comment if you concur.

@targos @refack
src,win: fix usage of deprecated v8::Object::Set
6e678b1 
PR-URL: nodejs#26735
Refs: nodejs#26733
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@refack refack removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 18, 2019
@refack refack merged commit 6e678b1 into nodejs:master Mar 18, 2019
@targos targos deleted the dep-win branch March 18, 2019 14:51
targos added a commit to targos/node that referenced this pull request Mar 27, 2019
@targos
src,win: fix usage of deprecated v8::Object::Set
45fc920 
PR-URL: nodejs#26735
Refs: nodejs#26733
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos added a commit that referenced this pull request Mar 27, 2019
@targos
src,win: fix usage of deprecated v8::Object::Set
8ba0da5 
PR-URL: #26735
Refs: #26733
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

+1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@targos @nodejs-github-bot @refack @cjihrig @richardlau