Skip to content

benchmark: use gfm for clarity #26710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

benchmark: use gfm for clarity #26710

wants to merge 1 commit into from

Conversation

@gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Mar 17, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Mar 17, 2019
@vsemozhetbyt vsemozhetbyt added the doc Issues and PRs related to the documentations. label Mar 17, 2019
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Mar 17, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2940/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 17, 2019
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Mar 19, 2019

Landed in 4e08daa
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Mar 19, 2019
@gengjiawen @vsemozhetbyt
benchmark: use gfm for clarity
4e08daa 
PR-URL: #26710
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@gengjiawen @targos
benchmark: use gfm for clarity
c7499a3 
PR-URL: nodejs#26710
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@gengjiawen @targos
benchmark: use gfm for clarity
0e4ae00 
PR-URL: #26710
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+2 more reviewers

@antsmartian antsmartian antsmartian approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gengjiawen @vsemozhetbyt @antsmartian @richardlau @BridgeAR @nodejs-github-bot