tools: enable getter-return lint rule #26615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v6.x
http2
BridgeAR
approved these changes
Mar 12, 2019
refack
approved these changes
Mar 17, 2019
shisama
approved these changes
Mar 18, 2019
shisama
reviewed
Mar 18, 2019
| @@ -492,7 +492,7 @@ Object.defineProperty(Socket.prototype, 'readyState', { | |||
|
|
|||
|
|
|||
| Object.defineProperty(Socket.prototype, 'bufferSize', { | |||
| get: function() { | |||
| get: function() { // eslint-disable-line getter-return | |||
There was a problem hiding this comment.
FYI, eslint-disable-line getter-return is unnecessary if this function returns undefined explicitly.
get: function() {
if (this._handle) {
return this[kLastWriteQueueSize] + this.writableLength;
}
return undefined;
}There was a problem hiding this comment.
@shisama in this case I thought it would be simplest to just add the comment. If you feel strongly about it, I can add the return undefined; instead.
There was a problem hiding this comment.
@cjihrig No, I am not particular about it. This is just a proposal. Thanks for your reply :)
jasnell
approved these changes
Mar 18, 2019
ZYSzys
approved these changes
Mar 19, 2019
BridgeAR
added
the
author ready
|
CI: https://ci.nodejs.org/job/node-test-pull-request/21898/ EDIT(cjihrig): CI was green. |
PR-URL: nodejs#26615 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Mar 26, 2019
PR-URL: #26615 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
PR-URL: nodejs#26615 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
PR-URL: #26615 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use getters a lot throughout core. I think it makes sense to lint for them returning values.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes