src: remove unused variables #26590
Closed
src: remove unused variables #26590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were causing compilation warnings.
nodejs-github-bot
added
the
c++
|
I wouldn't be opposed to fast tracking this. 👍 this if you agree? |
richardlau
approved these changes
Mar 11, 2019
hiroppy
approved these changes
Mar 11, 2019
refack
approved these changes
Mar 11, 2019
refack
added
the
author ready
|
I just cancelled my CI run :-D |
Me too, so https://ci.nodejs.org/job/node-test-pull-request/21429/ EDIT(cjihrig): Green resume CI: https://ci.nodejs.org/job/node-test-pull-request/21448/ |
himself65
approved these changes
Mar 12, 2019
|
Landed in 3753f9c. |
danbev
pushed a commit
that referenced
this pull request
Mar 12, 2019
These were causing compilation warnings. PR-URL: #26590 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Refael Ackermann <refack@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 13, 2019
These were causing compilation warnings. PR-URL: #26590 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Refael Ackermann <refack@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
These were causing compilation warnings. PR-URL: #26590 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were causing compilation warnings.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes