Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix more extra-semi warnings #26340

Closed
wants to merge 1 commit into from
Closed

src: fix more extra-semi warnings #26340

wants to merge 1 commit into from

Conversation

nornagon
Copy link
Contributor

Follow-up to #26330. Fixes warnings emitted by -Wc++98-compat-extra-semi.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Feb 27, 2019
@addaleax
Copy link
Member

addaleax commented Mar 2, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21123/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 2, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Mar 5, 2019 •
edited
Loading

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21212/ ✔️

@BridgeAR
Copy link
Member

BridgeAR commented Mar 5, 2019

Landed in a132b8a 🎉

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 5, 2019
@nornagon @BridgeAR
src: fix more extra-semi warnings
a132b8a 
PR-URL: nodejs#26340
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR closed this Mar 5, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@nornagon @BridgeAR
src: fix more extra-semi warnings
dc2119a 
PR-URL: nodejs#26340
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihalskiy mihalskiy mihalskiy approved these changes

@shisama shisama shisama approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nornagon @addaleax @BridgeAR @jasnell @shisama @mihalskiy @nodejs-github-bot