Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify http.ClientRequest path description #26259

Merged
merged 1 commit into from
Feb 26, 2019
Merged

doc: clarify http.ClientRequest path description #26259

merged 1 commit into from
Feb 26, 2019

Conversation

JungMinu
Copy link
Member

This PR clarifies http.ClientRequest path description.
Fixes: #25864

Checklist

@nodejs-github-bot
Copy link
Collaborator

@JungMinu sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Feb 22, 2019
@JungMinu JungMinu self-assigned this Feb 22, 2019
@JungMinu JungMinu requested a review from mscdex February 22, 2019 11:31
@JungMinu
doc: clarify http.ClientRequest path description
2e125cc 
Clarify `http.ClientRequest` path description.

Fixes: #25864
PR-URL: #26259
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@JungMinu
Copy link
Member Author

Landed in 2e125cc

@JungMinu JungMinu merged commit 2e125cc into nodejs:master Feb 26, 2019
@JungMinu JungMinu deleted the minwoo/fix-25864 branch February 26, 2019 02:07
addaleax pushed a commit that referenced this pull request Mar 1, 2019
@JungMinu @addaleax
doc: clarify http.ClientRequest path description
ff57a1c 
Clarify `http.ClientRequest` path description.

Fixes: #25864
PR-URL: #26259
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Merged
@kissofire kissofire mentioned this pull request Mar 7, 2021
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Mar 7, 2021
Open
@ron-a20 ron-a20 mentioned this pull request Mar 8, 2021
Open
@sitedata sitedata mentioned this pull request Mar 8, 2021
Open
@meghasfdc meghasfdc mentioned this pull request Mar 8, 2021
Open
@137717unity 137717unity mentioned this pull request Mar 8, 2021
Open
@Rednickle Rednickle mentioned this pull request Mar 8, 2021
Open
This was referenced Mar 11, 2021
Open
Open
This was referenced May 25, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request May 26, 2021
Open
This was referenced Apr 7, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Jan 30, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Jan 30, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jan 30, 2023
Open
@molllyn1 molllyn1 mentioned this pull request Jan 31, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jan 31, 2023
Open
@baby636 baby636 mentioned this pull request Jan 31, 2023
Open
This was referenced Jan 31, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@mscdex mscdex Awaiting requested review from mscdex

Assignees

@JungMinu JungMinu

Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: http.ClientRequest path property description needs clarification
3 participants
@JungMinu @nodejs-github-bot @lpinca