build: remove mips support #26192
Closed
build: remove mips support #26192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream V8 is dropping support for mips/mipsel/mips64/mips64el. This commit removes the build flags from the configure script and some loose ends from the documentation. Fixes: nodejs#26179
nodejs-github-bot
added
the
build
cjihrig
approved these changes
Feb 18, 2019
richardlau
approved these changes
Feb 18, 2019
richardlau
added
the
semver-major
|
I've defensively labelled this semver-major as I don't think this should land on any of our current releases. |
hashseed
approved these changes
Feb 18, 2019
There was a problem hiding this comment.
LGTM. It's sad to see this port being discontinued.
For those interested, this was the initial commit, nine years ago, almost exactly a year after Ryan made the initial commit for Node.js:
MIPS port initial commit
This is the first step in the MIPS port of V8. It adds assembler, disassembler and simulator for the MIPS32 architecture.
Contains stubbed out implementation of all the compiler/code generator infrastructure to make it all build.
Patch by Alexandre Rames from Sigma Designs Inc.
The ownership was transferred from Sigma Designs over to Home Jinni to Imagination Technologies to Wave Computing, with more or less the same folks working diligently to catch up with changes the V8 team made.
refack
approved these changes
Feb 18, 2019
Trott
approved these changes
Feb 18, 2019
|
Despite the semver-major label, I'm guessing a CITGM run here doesn't make much sense. (Anyone who feels differently should feel free to start one.) |
Trott
added
the
author ready
BridgeAR
approved these changes
Feb 20, 2019
jasnell
approved these changes
Feb 21, 2019
|
Landed in 9334e45. |
danbev
pushed a commit
that referenced
this pull request
Feb 22, 2019
Upstream V8 is dropping support for mips/mipsel/mips64/mips64el. This commit removes the build flags from the configure script and some loose ends from the documentation. PR-URL: #26192 Fixes: #26179 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yang Guo <yangguo@chromium.org> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Apr 23, 2019
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream V8 is dropping support for mips/mipsel/mips64/mips64el.
This commit removes the build flags from the configure script
and some loose ends from the documentation.
Fixes: #26179