test: remove unnecessary default tmpdir value in test #26177
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tmpdir.path` will never be falsy so there is no need to guard against that.
Member
Author
richardlau
approved these changes
Feb 18, 2019
Trott
added
the
author ready
danbev
approved these changes
Feb 18, 2019
cjihrig
approved these changes
Feb 18, 2019
jasnell
approved these changes
Feb 18, 2019
starkwang
approved these changes
Feb 19, 2019
Member
Author
|
Landed in d2c29bd |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 20, 2019
`tmpdir.path` will never be falsy so there is no need to guard against that. PR-URL: nodejs#26177 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 21, 2019
`tmpdir.path` will never be falsy so there is no need to guard against that. PR-URL: #26177 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
`tmpdir.path` will never be falsy so there is no need to guard against that. PR-URL: #26177 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tmpdir.pathwill never be falsy so there is no need to guard againstthat.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes