Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use emitter.listenerCount() in test-http-connect #26031

Closed
wants to merge 1 commit into from
Closed

test: use emitter.listenerCount() in test-http-connect #26031

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Feb 10, 2019

Use emitter.listenerCount() instead of the length property of the
array returned by emitter.listeners().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@lpinca
test: use emitter.listenerCount() in test-http-connect
e9128b9 
Use `emitter.listenerCount()` instead of the `length` property of the
array returned by `emitter.listeners()`.
@nodejs-github-bot
Copy link
Collaborator

@lpinca build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2562/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 10, 2019
@lpinca
Copy link
Member Author

lpinca commented Feb 10, 2019 •
edited
Loading

I understand this has very little value but using ee.listeners('foo').length when ee.listenerCount('foo') exists, triggers my OCD.

It's ok if this is not accepted.

@danbev
Copy link
Contributor

danbev commented Feb 13, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20752/

@addaleax
Copy link
Member

Landed in 2b090c1

@addaleax addaleax closed this Feb 13, 2019
addaleax pushed a commit that referenced this pull request Feb 13, 2019
@lpinca @addaleax
test: use emitter.listenerCount() in test-http-connect
2b090c1 
Use `emitter.listenerCount()` instead of the `length` property of the
array returned by `emitter.listeners()`.

PR-URL: #26031
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@lpinca lpinca deleted the fix/ocd branch February 14, 2019 06:06
targos pushed a commit that referenced this pull request Feb 14, 2019
@lpinca @targos
test: use emitter.listenerCount() in test-http-connect
64cc234 
Use `emitter.listenerCount()` instead of the `length` property of the
array returned by `emitter.listeners()`.

PR-URL: #26031
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lpinca @nodejs-github-bot @danbev @addaleax @jasnell