benchmark: refactor for consistent style#25944
Closed
Trott wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
nodejs-github-bot
added
benchmark
Member
Author
|
Benchmark tests in CI: https://ci.nodejs.org/job/node-test-commit-custom-suites/860/ ✅ |
Code in benchmark directory sometimes uses `function () {}` for
anonymous callbacks and sometimes uses `() => {}`. Multi-line arrays
sometimes have a trailing comma and sometimes do not. Update to always
use arrow functions for anonymous callbacks and trailing commas for
multiline arrays.
All benchmark code uses trailing commas on multi-line arrays and arrow functions for anonymous callbacks. Apply lint rules to that effect.
Trott
force-pushed
the
more-lint-benchmark
branch
from
43bc80f to
0855569
Compare
Member
Author
|
Benchmark tests in CI: https://ci.nodejs.org/job/node-test-commit-custom-suites/861/ ✅ |
gengjiawen
approved these changes
Feb 5, 2019
Member
Author
jasnell
approved these changes
Feb 6, 2019
Trott
added
the
author ready
Member
Author
|
Landed in d310d8d...2a21254 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 7, 2019
Code in benchmark directory sometimes uses `function () {}` for
anonymous callbacks and sometimes uses `() => {}`. Multi-line arrays
sometimes have a trailing comma and sometimes do not. Update to always
use arrow functions for anonymous callbacks and trailing commas for
multiline arrays.
PR-URL: nodejs#25944
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 7, 2019
All benchmark code uses trailing commas on multi-line arrays and arrow functions for anonymous callbacks. Apply lint rules to that effect. PR-URL: nodejs#25944 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 7, 2019
Code in benchmark directory sometimes uses `function () {}` for
anonymous callbacks and sometimes uses `() => {}`. Multi-line arrays
sometimes have a trailing comma and sometimes do not. Update to always
use arrow functions for anonymous callbacks and trailing commas for
multiline arrays.
PR-URL: #25944
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 7, 2019
All benchmark code uses trailing commas on multi-line arrays and arrow functions for anonymous callbacks. Apply lint rules to that effect. PR-URL: #25944 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Feb 15, 2019
This was referenced Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code in benchmark directory sometimes uses
function () {}for anonymouscallbacks and sometimes uses
() => {}. Multi-line arrays sometimeshave a trailing comma and sometimes do not. Update to always use arrow
functions for anonymous callbacks and trailing commas for multiline
arrays.
This is more churn than I was expecting, but after looking it over, it's right at the edge of my churn-tolerance, so I'm good with it. I'll be happy to do the backports to 11/10/8/6 as necessary, although probably
dont-land-onlabels are fine for code in thebenchmarkdirectory.¯\(ツ)/¯
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes