Revert "test: don't assume broadcast traffic is unfiltered" #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do you have a CI job for this or shall we submit one? |
|
looks good! a couple of apparently unrelated failures, one for osx and one for windows, so this LGTM |
This reverts commit 52e600a. Reverted for: * making the test fail with ENETUNREACH on OS X 10.8, and * making the test fail with EHOSTDOWN on OS X 10.9 and 10.10 when there is no network connectivity, and * leaving behind orphan processes that make subsequent tests fail with EADDRINUSE errors PR-URL: nodejs#259 Reviewed-By: Rod Vagg <rod@vagg.org>
Move parallel/test-dgram-broadcast-multi-process to test/internet. The test does not play nice with firewalls that restrict broadcast or multicast traffic, nor can it be rewritten to use only loopback traffic without running into platform-specific limitations, see also commits 52e600a and 236533c (TODO: update second one before landing.) PR-URL: nodejs#259 Reviewed-By: Rod Vagg <rod@vagg.org>
bnoordhuis
force-pushed
the
fix-broadcast-test
branch
from
78bef90
to
7266b75
Compare
|
Haha! |
This was referenced Jan 12, 2022
This was referenced Feb 28, 2022
This was referenced Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 52e600a.
Reverted for:
is no network connectivity, and
EADDRINUSE errors
R=@chrisdickinson or @rvagg