tools: update ESLint to 5.13.0 and replace deprecated configuration #25877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
changed the title
targos
approved these changes
Feb 1, 2019
Trott
added
the
author ready
Version 2.1.0 of dmn will get rid of .map and .ts files.
For `globals`, booleans are deprecated in favor strings `'readable'`/`'writeable'`.
cjihrig
approved these changes
Feb 2, 2019
hiroppy
approved these changes
Feb 3, 2019
|
Landed in 363ef3f...46af4c1 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 4, 2019
Version 2.1.0 of dmn will get rid of .map and .ts files. PR-URL: nodejs#25877 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 4, 2019
PR-URL: nodejs#25877 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 4, 2019
For `globals`, booleans are deprecated in favor strings `'readable'`/`'writeable'`. PR-URL: nodejs#25877 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
|
Should this be backported to |
Merged
This was referenced Feb 15, 2019
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit: Update the eslint-update script to use a newer version of
dmnso it will omit.tsand.mapfiles.Second commit: Update ESLint to 5.13.0.
Third commit: Replace deprecated configuration.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes