Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v11.x] src: pass along errors from PromiseWrap instantiation #25837

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Jan 30, 2019

Backport of one commit from #25734, with a minor conflict due to #23443 resolved.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

PR-URL: nodejs#25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v11.x labels Jan 30, 2019
@addaleax addaleax force-pushed the backport-promise-wrap-newinstance branch from 8cfe09a to a29a712 Compare January 30, 2019 23:35
@addaleax
Copy link
Member Author

addaleax commented Feb 3, 2019

@addaleax
Copy link
Member Author

addaleax commented Feb 3, 2019

Landed in 882902c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants