test: exclude additional test for coverage #25833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exclude async-hooks/test-callback-error as it seems to fail consistently when run with coverage on the docker ubuntu16 machines we plan to run the coverage sanity test on.
|
@fyi #bcoe |
danbev
approved these changes
Jan 31, 2019
richardlau
approved these changes
Jan 31, 2019
test/root.status
Outdated
| @@ -163,3 +163,4 @@ sequential/test-util-debug: SLOW | |||
| [$type==coverage] | |||
| js-native-api/test_function/test: PASS,FAIL,CRASH | |||
| js-native-api/test_general/testFinalizer: PASS,FAIL,CRASH | |||
| async-hooks/test-callback-error: PASS,FAIL,CRASH | |||
There was a problem hiding this comment.
Suggest sorting this (i.e. put this above the js-native-api tests).
|
Resume build due arm failures: https://ci.nodejs.org/job/node-test-pull-request/20495/ |
|
Ok CI run good, will land once 48hours is up. |
bcoe
approved these changes
Feb 1, 2019
|
Landed as c369b3e |
mhdawson
added a commit
that referenced
this pull request
Feb 1, 2019
Exclude async-hooks/test-callback-error as it seems to fail consistently when run with coverage on the docker ubuntu16 machines we plan to run the coverage sanity test on. PR-URL: #25833 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Coe <bencoe@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 1, 2019
Exclude async-hooks/test-callback-error as it seems to fail consistently when run with coverage on the docker ubuntu16 machines we plan to run the coverage sanity test on. PR-URL: #25833 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Coe <bencoe@gmail.com>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude async-hooks/test-callback-error as it seems
to fail consistently when run with coverage on
the docker ubuntu16 machines we plan to run the
coverage sanity test on.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes