test: add hasCrypto to worker-cleanexit-with-moduleload #25811
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, this test fails when configured --without-ssl:
=== release test-worker-cleanexit-with-moduleload ===
Path: parallel/test-worker-cleanexit-with-moduleload
events.js:173
throw er; // Unhandled 'error' event
^
internal/util.js:101
throw new ERR_NO_CRYPTO();
^
Error [ERR_NO_CRYPTO]:
Node.js is not compiled with OpenSSL crypto support
This commit as a check for crypto so that this test is skipped if there
is no crypto support.
Contributor
Author
gireeshpunathil
approved these changes
Jan 30, 2019
Member
|
sorry about that! |
Contributor
Author
No worries at all! 👍 |
cjihrig
approved these changes
Jan 30, 2019
richardlau
approved these changes
Jan 30, 2019
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
Is it only the https module that is causing an issue? (If so, could we just put a guard around the one module?)
lpinca
approved these changes
Jan 30, 2019
Contributor
Author
Good point. I've added a suggestion for this now. Thanks |
danbev
added
the
author ready
Contributor
Author
Contributor
Author
|
Re-build of failing node-test-commit-arm-fanned (✔️) |
Contributor
Author
|
Landed in d6a32cf. |
addaleax
pushed a commit
that referenced
this pull request
Feb 6, 2019
Currently, this test fails when configured --without-ssl:
=== release test-worker-cleanexit-with-moduleload ===
Path: parallel/test-worker-cleanexit-with-moduleload
events.js:173
throw er; // Unhandled 'error' event
^
internal/util.js:101
throw new ERR_NO_CRYPTO();
^
Error [ERR_NO_CRYPTO]:
Node.js is not compiled with OpenSSL crypto support
This commit as a check for crypto so that this test is skipped if there
is no crypto support.
PR-URL: #25811
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this test fails when configured
--without-ssl:This commit as a check for crypto so that this test is skipped if there
is no crypto support.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes